Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FvwmPager grid disappears #1014

Closed
rasatpc opened this issue Apr 19, 2024 · 4 comments
Closed

FvwmPager grid disappears #1014

rasatpc opened this issue Apr 19, 2024 · 4 comments
Labels
skip:changelog Issue/PR should skip CHANGELOG type:bug Something's broken!

Comments

@rasatpc
Copy link

rasatpc commented Apr 19, 2024 •
edited
Loading

  • Fvwm3 version (run: fvwm3 --version)

1.1.1 update {17 April) and the latest, miniature view disappears after 2nd time the desk is changed..... Desk 0, Desk 1, Desk 0, Desk 1 (disappears).

10th April update works fine.
@rasatpc rasatpc added the type:bug Something's broken! label Apr 19, 2024
@somiaj
Copy link
Collaborator

somiaj commented Apr 19, 2024

The pager is undergoing a lot of work right now, so if I broke something I'd like to fix it. But your description doesn't help me. Do you have a video screen shots of what is happening when the '2nd time desk is changed', also can you share a copy of the configuration you are using for the pager?

@rasatpc
Copy link
Author

rasatpc commented Apr 19, 2024 •
edited
Loading

Default config with RightPanel. Click on FvwmPager's lable 0 and another desk number back and forth a few times.

No hurry, developments for 1.1.1 look great.

somiaj added a commit that referenced this issue Apr 20, 2024
@somiaj
FvwmPager: Clean up DeskStyle initialization.
03822a2 
* Initialize new DeskStyle GC's when they are created. There is a dummy
  window available at this time for this, no need to wait.
* Don't put fonts in DeskStyle GC's, fonts are done with FwinString, which
  doesn't use these GCs.
* Fix a typo in the balloon colorset initialization, which would cause
  a crash trying to access a non allocated colorset. This fixes #1014.
@somiaj
Copy link
Collaborator

somiaj commented Apr 20, 2024

Thanks for the description, I was able to reproduce this. FvwmPager is crashing, which was due to a minor typo in the code.

I have been working on other things, so fixed this on top of that. Give #1015 a test.

@rasatpc
Copy link
Author

rasatpc commented Apr 20, 2024

Give #1015 a test.

Thanks, works fine.

@ThomasAdam ThomasAdam added the skip:changelog Issue/PR should skip CHANGELOG label Apr 20, 2024
somiaj added a commit that referenced this issue Apr 21, 2024
@somiaj
FvwmPager: Clean up DeskStyle initialization.
9d37ce5 
* Initialize new DeskStyle GC's when they are created. There is a dummy
  window available at this time for this, no need to wait.
* Don't put fonts in DeskStyle GC's, fonts are done with FwinString, which
  doesn't use these GCs.
* Fix a typo in the balloon colorset initialization, which would cause
  a crash trying to access a non allocated colorset. This fixes #1014.
* Protect against trying to update an invalid desk, causing a crash
  when changing colorsets.
somiaj added a commit that referenced this issue Apr 21, 2024
@somiaj
FvwmPager: Clean up DeskStyle initialization.
feba0bc 
* Initialize new DeskStyle GC's when they are created. There is a dummy
  window available at this time for this, no need to wait.
* Don't put fonts in DeskStyle GC's, fonts are done with FwinString, which
  doesn't use these GCs.
* Fix a typo in the balloon colorset initialization, which would cause
  a crash trying to access a non allocated colorset. This fixes #1014.
* Protect against trying to update an invalid desk, causing a crash
  when changing colorsets.
somiaj added a commit that referenced this issue Apr 21, 2024
@somiaj
FvwmPager: Clean up DeskStyle initialization.
62489a8 
* Initialize new DeskStyle GC's when they are created. There is a dummy
  window available at this time for this, no need to wait.
* Don't put fonts in DeskStyle GC's, fonts are done with FwinString, which
  doesn't use these GCs.
* Fix a typo in the balloon colorset initialization, which would cause
  a crash trying to access a non allocated colorset. This fixes #1014.
* Protect against updating gc's on default desk on colorset change, but
  colorset Pixels still need updated.
somiaj added a commit that referenced this issue Apr 21, 2024
@somiaj
FvwmPager: Clean up DeskStyle initialization.
fe88a70 
* Initialize new DeskStyle GC's when they are created. There is a dummy
  window available at this time for this, no need to wait.
* Don't put fonts in DeskStyle GC's, fonts are done with FwinString, which
  doesn't use these GCs.
* Fix a typo in the balloon colorset initialization, which would cause
  a crash trying to access a non allocated colorset. This fixes #1014.
* Protect against updating gc's on default desk on colorset change, but
  colorset Pixels still need updated.
* Fix some issues with updating on new_page and new_desk changes.
somiaj added a commit that referenced this issue Apr 21, 2024
@somiaj
FvwmPager: Clean up DeskStyle initialization.
5e09da9 
* Initialize new DeskStyle GC's when they are created. There is a dummy
  window available at this time for this, no need to wait.
* Don't put fonts in DeskStyle GC's, fonts are done with FwinString, which
  doesn't use these GCs.
* Fix a typo in the balloon colorset initialization, which would cause
  a crash trying to access a non allocated colorset. This fixes #1014.
* Protect against updating gc's on default desk on colorset change, but
  colorset Pixels still need updated.
* Fix some issues with updating on new_page and new_desk changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
skip:changelog Issue/PR should skip CHANGELOG type:bug Something's broken!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ThomasAdam @somiaj @rasatpc