FvwmPager: Code Cleanup and bugfixes. #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split up the two monolithic source FvwmPager.c and x_pager.c source
files into smaller files to help manage the code. The new structure is.
FvwmPager.c - main event loop
fpmonitors.c - fpmonitor methods.
init_pager.c - collection of all the initialization methods.
messages.c - respond to messages from fvwm.
x_pager.c - main still fairly large handling of the X windows
that build the pager, this includes processing events
and computing the position of all the windows.
x_update.c - update_foo methods for x_pager.c to update locations
and window graphics.
* Split up the large initialization method into smaller methods to better group related pieces of the initialization together. * Cleaup variable use, don't store font names, just create the font and discard the name, reducing pointer usage. * Cleanup ExitPager() to try to catch any remaining pointers to free. * Group the -transient pager initialization together and update it to place the pager under the pointer. In addition update the position using fpmonitors to ensure the pager isn't off screen.
Make ShapedLabels show the labels of all desks any monitor is currently in.
somiaj
force-pushed
the
js/pager-split
branch
4 times, most recently
from
62489a8 to
fe88a70
Compare
* Initialize new DeskStyle GC's when they are created. There is a dummy window available at this time for this, no need to wait. * Don't put fonts in DeskStyle GC's, fonts are done with FwinString, which doesn't use these GCs. * Fix a typo in the balloon colorset initialization, which would cause a crash trying to access a non allocated colorset. This fixes #1014. * Protect against updating gc's on default desk on colorset change, but colorset Pixels still need updated. * Fix some issues with updating on new_page and new_desk changes.
ThomasAdam
added
type:enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
ShapedLabesper-monitor aware so labels are shown for any desk a monitor is currently on.