Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FvwmConsoleC.pl front-end #379

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Remove FvwmConsoleC.pl front-end #379

merged 1 commit into from
Dec 22, 2020

Conversation

slazav
Copy link
Contributor

@slazav slazav commented Dec 22, 2020

Option -e in FvwmConsole module is still available.

@ThomasAdam ThomasAdam added area:doc Relates to documentation only type:breaking Issue is not backwards-compatible and will break configs/build labels Dec 22, 2020
@ThomasAdam ThomasAdam added this to the 1.0.3 milestone Dec 22, 2020
@ThomasAdam
Copy link
Member

Hi @slazav,

Thanks -- this looks good. Again though, the commit message needs work. I would suggest:

fvwmconsole: remove older FvwmConsoleC.pl wrapper

When FvwmConsole was first written, there was a companion wrapper written in perl which allowed for a different communication backend to be used with fvwm.

Over time, this was never really used and FvwmConsole itself is being shrunk down to become a compatibility shell for when FvwmPrompt isn't being used.  To reduce the confusion, it's time for FvwmConsoleC.pl to be removed.

@slazav
fvwmconsole: remove older FvwmConsoleC.pl wrapper
261cdf2 
When FvwmConsole was first written, there was a companion wrapper written in perl which allowed for a different communication backend to be used with fvwm.

Over time, this was never really used and FvwmConsole itself is being shrunk down to become a compatibility shell for when FvwmPrompt isn't being used.  To reduce the confusion, it's time for FvwmConsoleC.pl to be removed.
@ThomasAdam ThomasAdam merged commit 2648bdc into fvwmorg:master Dec 22, 2020
@slazav slazav deleted the remove_FvwmConsoleC.pl branch December 22, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@slazav slazav

Labels
area:doc Relates to documentation only type:breaking Issue is not backwards-compatible and will break configs/build
Projects
FVWM3
Status: Done
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@slazav @ThomasAdam