Skip to content
This repository has been archived by the owner on Jun 5, 2021. It is now read-only.

Incompatible with Bazel 0.25 due to transitive loads #54

Closed
apt-itude opened this issue Jun 3, 2019 · 0 comments · Fixed by #55
Closed

Incompatible with Bazel 0.25 due to transitive loads #54

apt-itude opened this issue Jun 3, 2019 · 0 comments · Fixed by #55

Comments

@apt-itude
Copy link
Contributor

defs.bzl exports all rules simply by loading them, which no longer works starting with Bazel 0.25. See this issue.

This manifests with the following types of errors:

 file '@bazel_javascript//:defs.bzl' does not contain symbol 'js_library'
apt-itude added a commit to 128technology/bazel-javascript that referenced this issue Jun 3, 2019
@apt-itude
Removed all transitive loads from defs.bzl
ee50d57 
Fixes fwouts#54
@apt-itude apt-itude mentioned this issue Jun 3, 2019
Merged
apt-itude added a commit to 128technology/bazel-javascript that referenced this issue Jun 3, 2019
@apt-itude
Removed all transitive loads from defs.bzl
c215264 
Fixes fwouts#54
@fwouts fwouts closed this as completed in #55 Jun 3, 2019
fwouts pushed a commit that referenced this issue Jun 3, 2019
@apt-itude @fwouts
Remove transitive loads (#55)
e4bfb37 
Fixes #54

This change creates explicit exports for all rules/macros in defs.bzl instead of relying on the deprecated behavior of implicitly exporting loaded symbols.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove transitive loads 128technology/bazel-javascript
1 participant
@apt-itude