Skip to content
This repository has been archived by the owner on Jun 5, 2021. It is now read-only.

Remove transitive loads #55

Merged
merged 5 commits into from
Jun 3, 2019

Conversation

apt-itude
Copy link
Contributor

Fixes #54

This change creates explicit exports for all rules/macros in defs.bzl instead of relying on the deprecated behavior of implicitly exporting loaded symbols.

@CLAassistant
Copy link

CLAassistant commented Jun 3, 2019

CLA assistant check
All committers have signed the CLA.

@apt-itude
Copy link
Contributor Author

Just a heads up: the buildifier check is failing because the latest version of the tool does not appear to have a -showlog flag. I ran it locally to make sure it's formatted properly. Maintainers, let me know if you want me to remove or change the flag to get CI passing.

Copy link
Owner

@fwouts fwouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fwouts fwouts merged commit e4bfb37 into fwouts:master Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with Bazel 0.25 due to transitive loads
3 participants