add id_ID Color #1754
add id_ID Color #1754
Conversation
|
bump @fzaninotto |
src/Faker/Provider/id_ID/Color.php
Outdated
| @@ -0,0 +1,39 @@ | |||
| <?php | |||
| /** | |||
| * Created by PhpStorm. | |||
There was a problem hiding this comment.
aaah i am sorry, i forget it, will remove it
There was a problem hiding this comment.
done i have remove it
|
@localheinz may i include link source for this color ? |
|
That would be helpful! |
|
@localheinz yeaah i have added link on source |
src/Faker/Provider/id_ID/Color.php
Outdated
| ); | ||
|
|
||
| /** | ||
| * @link http://listeningsection.blogspot.com/2017/08/100-nama-warna-dalam-bahasa-inggris.html |
There was a problem hiding this comment.
the content on this site is copyrighted. Please find a datasource compatible with Faker's MIT license
There was a problem hiding this comment.
sorry for my mistake, now i fix it use data from wikipedia, but some data i change with manual translate
src/Faker/Provider/id_ID/Color.php
Outdated
| * @link https://www.yec.co.id/inggris/nama-nama-warna-dalam-bahasa-inggris/ | ||
| **/ | ||
| protected static $allColorNames = array( | ||
| 'Merah Indian', 'Koral Terang', 'Salmon', 'Salmon Gelap', 'Salmon Terang', 'Krimson', 'Merah', |
There was a problem hiding this comment.
please order the items alphabetically, it eases detection of duplicates and the understanding of future diffs.
There was a problem hiding this comment.
What about adding a unit test for this purpose?
There was a problem hiding this comment.
i done for fix order item.
|
@rslhdyt bump, can u check my source |
keep trying, and give the best |
|
what a good innovation! |
|
@cacing69 Ok Mas |
|
@rslhdyt thank you mas 😄 |
|
I confirm that this is true, can someone approve |
|
Thanks! |
i add some color for id_ID provider