Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

add id_ID Color #1754

Merged
merged 9 commits into from
Sep 17, 2019
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/Faker/Provider/id_ID/Color.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
<?php
/**
* Created by PhpStorm.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this phpdoc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaah i am sorry, i forget it, will remove it

Copy link
Contributor Author

@cacing69 cacing69 Aug 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done i have remove it

* User: Cacing
* Date: 22/08/2019
* Time: 14:39
*/

namespace Faker\Provider\id_ID;


class Color extends \Faker\Provider\Color
{
protected static $safeColorNames = array(
'abu-abu', 'biru', 'biru dongker', 'biru laut', 'coklat', 'emas', 'hijau', 'hitam', 'kuning',
'magenta', 'mawar', 'merah', 'merah marun', 'merah jambu', 'nila', 'jingga', 'perak', 'putih', 'ungu',
'cokelat',
);

protected static $allColorNames = array(
'Merah Indian', 'Koral Terang', 'Salmon', 'Salmon Gelap', 'Salmon Terang', 'Krimson', 'Merah',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please order the items alphabetically, it eases detection of duplicates and the understanding of future diffs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about adding a unit test for this purpose?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overkill IMO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i done for fix order item.

'Merah Bata', 'Merah Tua', 'Merah Muda', 'Merah Muda Panas', 'Koral',
'Merah Oranye', 'Jingga Tua', 'Jingga', 'Emas', 'Kuning', 'Kuning Terang', 'Khaki', 'Dark Khaki',
'Kuning Lemon', 'Plum', 'Magenta', 'Ungu', 'Hijau Kekuningan', 'Hijau Lemon',
'Hijah Gelap', 'Biru', 'Hitam', 'Abu-Abu Tua', 'Abu-Abu Muda', 'Putih', 'Cokelat', 'Perak',
'Kuning Sawo', 'Ungu Lembayung', 'Kuning Aprikot', 'Biru Laut', 'Cokelat Kemerahan',
'Biru Langit', 'Abu-Abu Kecoklatan', 'Hijau Pudar', 'Jingga Muda', 'Arang', 'Hijau Muda Kekuningan',
'Cokelat Tua', 'Tembaga', 'Merah Kekunung-Kuningan', 'Krem', 'Merah Tua Terang', 'Biru Terang',
'Gelap', 'Ungu Terong', 'Hijau Zamrud', 'Hijau Hutan', 'Merah Muda Terang', 'Coklat Keemasan',
'Nila', 'Putih Gading', 'Hijau Lumut', 'Hitam Pekat', 'Kuning Pucat',
'Ungu Muda', 'Kuning Muda', 'Putih Terang', 'Hijau Cerah', 'Merah Muda Keunguan Pudar', 'Hijau Tua',
'Merah Keungu Unguan', 'Ungu Lembayung Muda', 'Kuning Kehijauan Pucat', 'Hijau Neon',
'Kuning Kecoklatan Tua', 'Paster', 'Peach', 'Biru Pucat', 'Sawo Matang', 'Jingga Labu',
'Pelangi', 'Mawar', 'Delima', 'Cokelat Kekuningan', 'Kuning Jingga', 'Biru Nilam',
'Merah Muda Kekuningan', 'Merah Tomat', 'Biru Keabu-abuan', 'Biru Baja',
'Biru Dongker', 'Hijau Kebiruan', 'Biru Kehijauan', 'Biru Laut Tua', 'Ungu Kebiruan', 'Coklat Gandum',
'Hijau Abu-Abu', 'Ungu Kecoklatan'
);
}