This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
add id_ID Color #1754
Merged
Merged
add id_ID Color #1754
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9cf6b44
add id_ID Color
7a34166
remove duplicate value emas
4588de2
remove phpdocs
cacing69 2a3b721
add link on Color for id provider
cacing69 046ec27
change source data and reorder item
967499c
some type, change from coklat to cokelat
cacing69 5ff9e54
fix comma on item variable
31bb60a
resolve
733226a
break lines by capital letter
fzaninotto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
<?php | ||
/** | ||
* Created by PhpStorm. | ||
* User: Cacing | ||
* Date: 22/08/2019 | ||
* Time: 14:39 | ||
*/ | ||
|
||
namespace Faker\Provider\id_ID; | ||
|
||
|
||
class Color extends \Faker\Provider\Color | ||
{ | ||
protected static $safeColorNames = array( | ||
'abu-abu', 'biru', 'biru dongker', 'biru laut', 'coklat', 'emas', 'hijau', 'hitam', 'kuning', | ||
'magenta', 'mawar', 'merah', 'merah marun', 'merah jambu', 'nila', 'jingga', 'perak', 'putih', 'ungu', | ||
'cokelat', | ||
); | ||
|
||
protected static $allColorNames = array( | ||
'Merah Indian', 'Koral Terang', 'Salmon', 'Salmon Gelap', 'Salmon Terang', 'Krimson', 'Merah', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please order the items alphabetically, it eases detection of duplicates and the understanding of future diffs. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about adding a unit test for this purpose? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. overkill IMO There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i done for fix order item. |
||
'Merah Bata', 'Merah Tua', 'Merah Muda', 'Merah Muda Panas', 'Koral', | ||
'Merah Oranye', 'Jingga Tua', 'Jingga', 'Emas', 'Kuning', 'Kuning Terang', 'Khaki', 'Dark Khaki', | ||
'Kuning Lemon', 'Plum', 'Magenta', 'Ungu', 'Hijau Kekuningan', 'Hijau Lemon', | ||
'Hijah Gelap', 'Biru', 'Hitam', 'Abu-Abu Tua', 'Abu-Abu Muda', 'Putih', 'Cokelat', 'Perak', | ||
'Kuning Sawo', 'Ungu Lembayung', 'Kuning Aprikot', 'Biru Laut', 'Cokelat Kemerahan', | ||
'Biru Langit', 'Abu-Abu Kecoklatan', 'Hijau Pudar', 'Jingga Muda', 'Arang', 'Hijau Muda Kekuningan', | ||
'Cokelat Tua', 'Tembaga', 'Merah Kekunung-Kuningan', 'Krem', 'Merah Tua Terang', 'Biru Terang', | ||
'Gelap', 'Ungu Terong', 'Hijau Zamrud', 'Hijau Hutan', 'Merah Muda Terang', 'Coklat Keemasan', | ||
'Nila', 'Putih Gading', 'Hijau Lumut', 'Hitam Pekat', 'Kuning Pucat', | ||
'Ungu Muda', 'Kuning Muda', 'Putih Terang', 'Hijau Cerah', 'Merah Muda Keunguan Pudar', 'Hijau Tua', | ||
'Merah Keungu Unguan', 'Ungu Lembayung Muda', 'Kuning Kehijauan Pucat', 'Hijau Neon', | ||
'Kuning Kecoklatan Tua', 'Paster', 'Peach', 'Biru Pucat', 'Sawo Matang', 'Jingga Labu', | ||
'Pelangi', 'Mawar', 'Delima', 'Cokelat Kekuningan', 'Kuning Jingga', 'Biru Nilam', | ||
'Merah Muda Kekuningan', 'Merah Tomat', 'Biru Keabu-abuan', 'Biru Baja', | ||
'Biru Dongker', 'Hijau Kebiruan', 'Biru Kehijauan', 'Biru Laut Tua', 'Ungu Kebiruan', 'Coklat Gandum', | ||
'Hijau Abu-Abu', 'Ungu Kecoklatan' | ||
); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this phpdoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aaah i am sorry, i forget it, will remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done i have remove it