Skip to content
This repository has been archived by the owner on Dec 11, 2020. It is now read-only.

Add missing lowercasing to the "no intl-ext" fallback #723

Closed
wants to merge 1 commit into from
Closed

Add missing lowercasing to the "no intl-ext" fallback #723

wants to merge 1 commit into from

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Oct 4, 2015

Follow-up to #711.

@fzaninotto
Copy link
Owner

Misleading. A method called transillterate should only translitterate. I guess it's the caller's responsibility to compose with a call to lowercase.

@fzaninotto fzaninotto closed this Oct 4, 2015
@vlakoff
Copy link
Contributor Author

vlakoff commented Oct 4, 2015

Agree, I thought the same. Improved PR to come.

This was referenced Oct 4, 2015
Merged
Merged
@vlakoff vlakoff deleted the transliterate branch October 12, 2015 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlakoff @fzaninotto