This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Optimize userName and domainWord #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
added a commit
that referenced
this pull request
Oct 6, 2015
Optimize userName and domainWord
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies for the amount of PRs! (and there is one more to come after)
Something I forgot when moving from #723 to #725.
transliterate()result is surely ascii compatible[1]. And in any hypothetical worst-case scenario (like user messing low level),mb_strtolower()wouldn't fix anything anyways, but make upfront bug less noticeable.The contract is clear:
transliterate()result is ascii compatible. And with this commit we save 2 function calls each time, which is great.[1]
return preg_replace('/[^A-Za-z0-9_.]/u', '', $transString);