Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'qualifier' back to core-im-source.yaml #160

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

mbrush
Copy link
Contributor

@mbrush mbrush commented Jul 4, 2024

Larry dropped this in he latest refactor. But IMO defining qualifier in the core-im is important for two reasons. It is useful to explain what the notion of a ‘qualifier’ means and what it is used for in the modeling framework. And it is necessary to implement the conceptual specialization I describe above, which happens when a specific qualifier property is defined in a Statement profile.

in this PR:

  • 'qualifier' is named using the singular name - consistent with it not taking an array in the core-im, and supporting the allowed 1:m specialization that is done when profiling this property.
  • the property takes ‘object’ (which by my understanding covers any data type, including string, enums, IRIs, or nested/referenced structured objects)
  • I gave it a clear and informative free-text description, and added a ‘comment’ that explains how this property can get profiled into >1 more specific qualifier properties

Larry dropped this in he latest refactor. But IMO defining `qualifier` in the core-im is important for two reasons. It is useful to explain what the notion of a ‘qualifier’ means and what it is used for in the modeling framework. And it is necessary to implement the conceptual specialization I describe above, which  happens when a specific qualifier property is defined in a Statement profile.
Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving the placeholder comment to help us come to a resolution on how to deal with generating qualifiers in metaschema manager

@larrybabb larrybabb merged commit e85f2ed into 1.x Jul 9, 2024
3 checks passed
@larrybabb larrybabb deleted the mbrush-patch-2-reinstate-qualifier-1 branch July 9, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants