Update StudyResult.dataItem property #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here I update StudyResult.dataItem property to align with analogous paradigm for qualifier specialization In #134 @larrybabb proposed that profiles can define specific qualifiers as ‘new’ properties as long as they are named as qualifiers. @mbrush clarified that these are not truly ‘new’ – as conceptually they specialize the core-im `Statement.qualifier` property. The use of `StudyResult.dataItem` property in StudyResult profiles is quite analogous, in that profiling often requires defining >1 specialization of this property for different specific data types. In this PR, we update the definition of StudyResult.dataItem in the core-im to support this paradigm and align with how `Statement.qualifier` is defined in PR #___ Specifically: - removed the existing `dataItems` property - replaced it with a ‘dataItem’ property (singular, consistent with it not taking an array in the core-im) - made it take an ‘object’ (which by my understanding covers strings) - gave it a clear and informative free-text description - added a ‘comment’ that explains how this property can get profiled into >1 more specific properties. In the future we might consider some type of flag/keyword on this core-im property to explicitly mark it as amenable to 1:m specialization in profiles – if this helps with conceptual clarity or computational validation.
larrybabb
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I update StudyResult.dataItem property to align with analogous paradigm for qualifier specialization
Background and Motivation
In issue #134 @larrybabb proposed that profiles can define specific qualifiers as ‘new’ properties as long as they are named as qualifiers. @mbrush clarified that these are not truly ‘new’ – as conceptually they specialize the core-im
Statement.qualifierproperty.The use of
StudyResult.dataItemproperty in StudyResult profiles is quite analogous, in that profiling often requires defining >1 specialization of this property for different specific data types.Changes
In this PR, we update the definition of StudyResult.dataItem in the core-im to support this paradigm and align with how
Statement.qualifieris defined in PR #160Specifically:
dataItemspropertyIn the future we might consider some type of flag/keyword on this core-im property to explicitly mark it as amenable to 1:m specialization in profiles – if this helps with conceptual clarity or computational validation.