Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit hook + resolve warnings for 2-alpha #262

Open
korikuzma opened this issue Sep 18, 2023 · 2 comments
Open

Add pre-commit hook + resolve warnings for 2-alpha #262

korikuzma opened this issue Sep 18, 2023 · 2 comments
Labels
2.0-alpha Issues related to VRS 2.0-alpha branch cleanup Changes only making code cleaner & do not change how the code works nor the outputs produced priority:low Low priority Stale-exempt

Comments

@korikuzma
Copy link
Contributor

No description provided.

@korikuzma korikuzma added 2.0-alpha Issues related to VRS 2.0-alpha branch priority:low Low priority cleanup Changes only making code cleaner & do not change how the code works nor the outputs produced labels Sep 18, 2023
korikuzma added a commit that referenced this issue Sep 18, 2023
@korikuzma
revert: temporarily rm pylint static analysis from gh actions
d8e639a 
* Will add back in #262
@korikuzma
Copy link
Contributor Author

This is for pylint

@korikuzma korikuzma mentioned this issue Sep 19, 2023
Merged
korikuzma added a commit that referenced this issue Sep 26, 2023
@korikuzma
feat!: update VCFAnnotator + AlleleTranslator (#265)
65aee0a 
* Updates `VCFAnnotator` and `AlleleTranslator` with changes done in the `main` branch. 
  *  `VCFAnnotator` changes: 
    * Use click
    * Allow for additional info fields: `VRS_Allele_IDs`, `VRS_Starts`, `VRS_Ends`, `VRS_States`
    * Add docs for how to use the tool
  * `AlleleTranslator` changes
      * Update `gnomad_re` pattern
      * Sets default `fmt` in `translate_from`
      * Validates `_from_gnomad` actual reference sequence matches expected reference sequence
      * Use valid examples in `translate_from` methods docstring
      * `assembly_name` can now be set via kwargs
 * Removes pylint check in GH Actions. Will add back in #262
@github-actions GitHub Actions
Copy link

This issue was marked stale due to inactivity.

@github-actions github-actions bot added the Stale label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.0-alpha Issues related to VRS 2.0-alpha branch cleanup Changes only making code cleaner & do not change how the code works nor the outputs produced priority:low Low priority Stale-exempt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsstevenson @korikuzma