Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update VCFAnnotator + AlleleTranslator #265

Merged
merged 10 commits into from
Sep 26, 2023
Merged

Conversation

korikuzma
Copy link
Contributor

close #211

Notes:

  • Updates VCFAnnotator and AlleleTranslator with changes done in the main branch.
    • VCFAnnotator changes:
    • Use click
    • Allow for additional info fields: VRS_Allele_IDs, VRS_Starts, VRS_Ends, VRS_States
    • Add docs for how to use the tool
    • AlleleTranslator changes
      • Update gnomad_re pattern
      • Sets default fmt in translate_from
      • Validates _from_gnomad actual reference sequence matches expected reference sequence
      • Use valid examples in translate_from methods docstring
      • assembly_name can now be set via kwargs
  • Removes pylint check in GH Actions. Will add back in Add pre-commit hook + resolve warnings for 2-alpha #262

@korikuzma korikuzma added enhancement New feature or request 2.0-alpha Issues related to VRS 2.0-alpha branch labels Sep 19, 2023
@korikuzma korikuzma self-assigned this Sep 19, 2023
@korikuzma korikuzma requested review from a team as code owners September 19, 2023 15:20
@korikuzma korikuzma removed request for a team September 19, 2023 15:21
@korikuzma korikuzma merged commit 65aee0a into 2-alpha Sep 26, 2023
8 checks passed
@korikuzma korikuzma deleted the fix-vcf-anno branch September 26, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0-alpha Issues related to VRS 2.0-alpha branch enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants