feat!: update vrs/common models #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close #415 * only support 3 most recent python versions (3.10, 3.11, 3.12) * change development python version from 3.10 to 3.12 * re-run cassettes
* ordered:false -> serializer should always sort the array before computing the digest so that regardless of the order, the digest always comes out the same * ordered: true -> do not sort the items before digesting, so digests can be different based on ordering of array
korikuzma
commented
Jul 5, 2024
There was a problem hiding this comment.
Wondering if we should split these out into core-im vs domain entity modules?
There was a problem hiding this comment.
If so, might do this in a separate PR
korikuzma
commented
Jul 5, 2024
There was a problem hiding this comment.
I deleted test_vrs.py and renamed test_vrs2.py to test_vrs.py. These were essentially the same, but test_vrs2.py had more tests.
|
Going to do one more look over in the morning. Then I think I'm ready to mark ready for review. |
korikuzma
changed the title
jsstevenson
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #409 , #116
use_enum_valuesfrom Pydantic config. We didn't use this in all models, so not sure if there was a purpose for it.Could definitely get some other eyes on this to make sure I didn't miss anything