Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCFAnnotator updates to skip REF alleles and emit correct INFO field definitions #299

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

ehclark
Copy link
Contributor

@ehclark ehclark commented Dec 14, 2023

Implemented changes for #295 and #296.

The VCFAnnotator tool now accepts an additional parameter that controls whether VRS computation is performed for REF alleles in addition to ALT alleles. For large scale VRS computation on VCF input, this will allow users to reduce compute time and costs if REF allele VRS IDs are not required.

The VRS INFO field definitions in the output VCF have also been modified to have the correct value for the Number attribute: either R or A depending on whether REF alleles are included. This change also required passing the VRS INFO field values to the VCF output writer as arrays, rather than strings.

Copy link
Contributor

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@larrybabb larrybabb merged commit 629cb88 into 2-alpha Dec 15, 2023
8 checks passed
@larrybabb larrybabb deleted the issue-295-296 branch December 15, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants