Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the getting_started notebooks and removing the rest. #402

Merged
merged 5 commits into from
Apr 20, 2024

Conversation

toneillbroad
Copy link
Contributor

No description provided.

@toneillbroad toneillbroad requested review from a team as code owners April 18, 2024 20:35
Copy link
Contributor

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toneillbroad overall fantastic work! Made some minor suggestions

notebooks/getting_started/1 Quick Start.ipynb Outdated Show resolved Hide resolved
notebooks/getting_started/1 Quick Start.ipynb Outdated Show resolved Hide resolved
notebooks/getting_started/1 Quick Start.ipynb Outdated Show resolved Hide resolved
notebooks/getting_started/1 Quick Start.ipynb Outdated Show resolved Hide resolved
notebooks/getting_started/1 Quick Start.ipynb Outdated Show resolved Hide resolved
notebooks/getting_started/README.md Outdated Show resolved Hide resolved
notebooks/getting_started/README.md Show resolved Hide resolved
notebooks/getting_started/README.md Show resolved Hide resolved
Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job Terry!

@larrybabb larrybabb force-pushed the notebook-cleanup-and-getting-started-series branch from 7332678 to 07e0ca8 Compare April 19, 2024 12:35
@toneillbroad
Copy link
Contributor Author

@korikuzma thanks for the thorough review and great suggestions. I'd appreciate your feedback of the unresolved comments above please.

Copy link
Contributor

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo! But I think we can merge after this unless other people have suggestions

Copy link
Contributor

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@toneillbroad toneillbroad merged commit 096b124 into main Apr 20, 2024
8 checks passed
@toneillbroad toneillbroad deleted the notebook-cleanup-and-getting-started-series branch April 20, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants