Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GenotypeMember.variation
. We already allow this compact syntax forAllele
, so I think it makes sense to extend it toAdjacency
.Adjacency
toMolecularVariation
, since Adjacency inherits from it and seems to match the definition. However, I'm not familiar with all the use cases of theMolecularVariation
class, so let me know if this should be revertedSequenceLocation.sequenceReference
onadjoinedSequences
in the second genotype member. I have seen this syntax used within aHaplotype
before but not aGenotype
. Can you confirm that this is allowed on aGenotype
?