Autoscroll after mounting in case preserveScrollTop is false
#32
Conversation
| this.scrollDown = false; | ||
| } | ||
| } | ||
| componentDidUpdate = this.scroll; |
There was a problem hiding this comment.
This looks a tiny bit surprising, let's turn this into a regular declaration instead?
There was a problem hiding this comment.
Sure :)
By regular declaration you mean componentDidUpdate() { this.scroll(); }?
There was a problem hiding this comment.
If so, agree, in my case we pass prevProps and prevState to this.scroll, which is unnecessary.
There was a problem hiding this comment.
First question: yes.
Second question: not sure I understand. Can it just take no arguments?
There was a problem hiding this comment.
Yes, sorry, I wasn't clear enough. I meant that one disadvantage of componentDidUpdate = this.scroll (as I did before) is that it creates an impression that this.scroll is called as this.scroll(prevProps, prevState) as componentDidUpdate passes those arguments.
…lse` Change componentDidUpdate function
Autoscroll after mounting in case `preserveScrollTop` is `false`
|
Out in 1.0.4. |
Related to zalmoxisus/redux-devtools-extension#38