-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverse Order of Actions #38
Comments
Thanks for the feedback and the suggestion! I think solving the issue #34 would solve this as well, wouldn't it? |
I think reverse order would be better-- Say you're up looking at an action from 10 actions ago, then boom, an action comes in and it autoscrolls you back down. Could get annoying :P Also having the latest action at the top matches most normal "feeds" around the web (facebook feed, twitter feed, etc. all have latest stuff at the top) |
Actually, autoscrolling to the bottom works (the issue is only with initial rendering of the monitor), and, as you see, it doesn't bother you when you scroll to a specific action (autoscrolling happens only when you are at the bottom). I'm neither pro nor against this proposal, but it should be advocated and implemented on the monitor side, otherwise we'll still have autoscrolling to bottom happen on the log monitor. It wouldn't be efficient and sustainable to revert actions' array and states' object every time an action is dispatched, way better to just revert the loop. Also I want the extension behavior to be the same as Redux DevTools, so one could easy switch from the classical implementation of Redux DevTools to the extension and back. |
The log monitor should already autoscroll if you didn't scroll up manually. |
@gaearon, yes, it does. The issue is with the initial rendering when having already actions stored in the liftedStore. We should have triggered that also for |
Ah right. I'm happy to accept a PR that scrolls to bottom in |
@gaearon, I'm afraid it could be a problem when using |
Should work in Also the idea of reversed actions for the notifications is good and, actually, implemented in |
In |
When I open up the DevTools, I'm only really interested in the current state, not the first one.
Would be nice if the actions were reversed, so the latest one was up top.
If I get some time, I'll do a PR, but this should be super quick to do if ya'll agree :)
(BTW, this tool is freakin' awesome!!)
The text was updated successfully, but these errors were encountered: