Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ESLint 8.x #495

Closed
MichaelDeBoey opened this issue Aug 29, 2021 · 3 comments
Closed

Support ESLint 8.x #495

MichaelDeBoey opened this issue Aug 29, 2021 · 3 comments

Comments

@MichaelDeBoey
Copy link
Contributor

MichaelDeBoey commented Aug 29, 2021 •
edited
Loading

ESLint v8.0.0 is released 🎉

It would be awesome to have official ESLint 8 support. 👊
I'm happy to help where I can of course 🙂
This was referenced Aug 29, 2021
Closed
Closed
Merged
Closed
Merged
This was referenced Oct 10, 2021
Closed
Closed
@KillWolfVlad KillWolfVlad mentioned this issue Oct 11, 2021
Closed
23 tasks
@sabertazimi sabertazimi mentioned this issue Oct 12, 2021
Merged
1 task
@EvHaus
Copy link

EvHaus commented Oct 14, 2021 •
edited
Loading

Looks like the plugin doesn't support it out-of-the-box. Trying to use it with eslint@8.0.1 gives me this:

ESLint: 8.0.1

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/rules/no-unused-expressions' is not defined by "exports" in /myproject/node_modules/eslint/package.json
    at throwExportsNotFound (internal/modules/esm/resolve.js:299:9)
    at packageExportsResolve (internal/modules/esm/resolve.js:522:3)
    at resolveExports (internal/modules/cjs/loader.js:449:36)
    at Function.Module._findPath (internal/modules/cjs/loader.js:489:31)
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:875:27)
    at Function.Module._load (internal/modules/cjs/loader.js:745:27)
    at Module.require (internal/modules/cjs/loader.js:961:19)
    at require (/myproject/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
    at Object.<anonymous> (/myproject/node_modules/eslint-plugin-flowtype/dist/rules/noUnusedExpressions.js:8:51)
    at Module._compile (/myproject/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)

@MichaelDeBoey
Copy link
Contributor Author

@EvHaus That's why I created #496 😉

@mdjermanovic mdjermanovic mentioned this issue Oct 20, 2021
Closed
1 task
@EvHaus
Copy link

EvHaus commented Oct 27, 2021

Upgrading the eslint-plugin-flowtype@8.0.2 fixed my issue. Thank you!

@gajus gajus closed this as completed Oct 27, 2021
This was referenced Oct 29, 2021
Closed
Closed
sounisi5011 added a commit to sounisi5011/npm-packages that referenced this issue Dec 20, 2021
@sounisi5011
chore(encrypted-archive): remove ESLint config for React Native
ae13882 
+ `@react-native-community/eslint-config@^2.0.0` does not work

    This includes `eslint-plugin-flowtype@^7.0.0` for dependencies.
    However, `eslint-plugin-flowtype@^7.0.0` does not work with ESLint 8.
    [This has been fixed in version `8.0.2`], but `@react-native-community/eslint-config@^2.0.0` does not use this.

[This has been fixed in version `8.0.2`]: gajus/eslint-plugin-flowtype#495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support ESLint 8.x MichaelDeBoey/eslint-plugin-flowtype
3 participants
@EvHaus @gajus @MichaelDeBoey