Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-config-react-app): support ESLint 8.x #11375

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

MichaelDeBoey
Copy link
Contributor

@MichaelDeBoey MichaelDeBoey commented Sep 4, 2021

ESLint v8.0.0 is released 🎉

Dependencies should be compatible with ESLint 8 too before we can merge this one:

Dependencies for react-scripts should be compatible with ESLint 8 too before we can merge this one:


Closes #11374

BREAKING CHANGE: Requires ESLint@^8.0.0

@ahummel25
Copy link

ahummel25 commented Oct 11, 2021

Any timeline for this getting fixed/merged now that eslint v8 is live?

@MichaelDeBoey
Copy link
Contributor Author

@ahummel25 As you can see in the OP, not all dependencies are updated for ESLint 8.x (yet), so we'll have to wait for them first.

@karlhorky
Copy link

karlhorky commented Oct 15, 2021

@MichaelDeBoey should jest-community/eslint-plugin-jest#940 be added to the eslint-plugin-jest list above? It seems like this was just merged?

This was released in a minor (25.1.0): https://github.com/jest-community/eslint-plugin-jest/releases/tag/v25.1.0

@ianldgs
Copy link

ianldgs commented Nov 11, 2021

Friendly ping: I think everything is merged now!

@MichaelDeBoey
Copy link
Contributor Author

@ianldgs I'll update the PR whenever I have some time 👍

@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review November 14, 2021 15:16
@iansu iansu added this to the 5.0 milestone Nov 17, 2021
@dannyphillips
Copy link

Any update on when we plan to merge/release this?

@raix
Copy link
Contributor

raix commented Nov 27, 2021

@MichaelDeBoey seems like some tests are still failing - I could not find any relations in the eslint release notes but we could try to update to 8.3.0 and see if that fixes anything - if not we'll have to take a closer look cc. @iansu @mrmckeb

@raix raix mentioned this pull request Nov 27, 2021
@raix
Copy link
Contributor

raix commented Nov 27, 2021

Actually the main branch seems to be failing in node 16/mac os on the same test "uses yarn as the package manager" - Will have to investigate

@GoetzGoerisch
Copy link

@raix looks like a timeout only problem for me.
The PR integration tests run fine on our fork. umati#1

@mrmckeb
Copy link
Contributor

mrmckeb commented Dec 1, 2021

@MichaelDeBoey, this is great - thanks. We'd like to merge this in, but it looks like there are some dependency updates.

If you can take a look, that would be great. Otherwise I can jump in and help!

It might also be worth bumping to ESLint 8.3.0 (and spot check the other versions).

@raix
Copy link
Contributor

raix commented Dec 1, 2021

Tests should be fixed on main now 🤞

@GoetzGoerisch
Copy link

@MichaelDeBoey rebased and updated branch here: https://github.com/umati/create-react-app/tree/eslint-8 please integrate if you like.

BREAKING CHANGE: Requires ESLint@^8.0.0
@MichaelDeBoey
Copy link
Contributor Author

@mrmckeb I've rebase this onto main and updated all ESLint related packages to their latest version, so I think this one is good to be merged now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[eslint-config-react-app] Support ESLint 8.x