Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ESLint 8.x #118

Closed
MichaelDeBoey opened this issue Sep 4, 2021 · 9 comments · Fixed by #121
Closed

Support ESLint 8.x #118

MichaelDeBoey opened this issue Sep 4, 2021 · 9 comments · Fixed by #121

Comments

@MichaelDeBoey
Copy link

MichaelDeBoey commented Sep 4, 2021

ESLint v8.0.0 is released 🎉

It would be awesome to have official ESLint 8 support. 👊
I'm happy to help where I can of course 🙂

@snitin315
Copy link
Member

PR welcome :)

@jsg2021
Copy link
Contributor

jsg2021 commented Sep 6, 2021

I don't think this project uses any of the removed/deprecated exports. For example, this uses the ESLint export already. As far as I know, it should already be compatible.

@jsg2021
Copy link
Contributor

jsg2021 commented Sep 6, 2021

Yeah, I think the only thing needed is the peerDep to be extended with ^7.0.0 || >=8.0.0-beta.0 <9

@MichaelDeBoey
Copy link
Author

@jsg2021 The deprecated CLIEngine is also used

chalkygames123 added a commit to chalkygames123/front-end-template that referenced this issue Oct 19, 2021
@tipleavalentin
Copy link

Any updates?
I get this issue on eslint 8.0.0/8.0.1:
Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/cli-engine/formatters/stylish' is not defined by "exports"

@alexander-akait
Copy link
Member

@ricardogobbosouza hello, can you look?

@tipleavalentin
Copy link

@ricardogobbosouza hello, can you look?

Hi! I got a reply on the eslint package:
"This is an internal module. As of ESLint v8.0.0, internal modules cannot be accessed."

This config works:
new ESLintPlugin({
failOnError: true,
formatter: 'stylish'
})

@alexander-akait
Copy link
Member

Looks like stylish was removed from eslint

@ricardogobbosouza
Copy link
Collaborator

I will add support for eslint 8 by the end of the week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants