feat: require-exact-type detects nested objects #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, including nested ones. Also added a fixer.
Marcosld
commented
Mar 19, 2020
| @@ -19,7 +19,7 @@ | |||
| "chai": "^4.2.0", | |||
| "eclint": "^2.8.1", | |||
| "eslint": "^5.13.0", | |||
| "eslint-config-canonical": "^17.3.4", | |||
| "eslint-config-canonical": "^18.1.1", | |||
There was a problem hiding this comment.
This dependency was causing an error because in this commit import-js/eslint-plugin-import@1a3a128 one of the dependent rules was updated.
| @@ -88,7 +88,7 @@ const generateOrderedList = (context, sort, properties) => { | |||
| const beforePunctuator = source.getTokenBefore(nextPunctuator, { | |||
There was a problem hiding this comment.
Reported by rules when I updated the plugin (prefer slice to substring)
| @@ -7,199 +7,199 @@ export default { | |||
| // "always" (by default) | |||
There was a problem hiding this comment.
Keys were unordered (linting rule)
|
🎉 This PR is included in version 4.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
require-exact-type should now detect all object type declarations, not just type aliases. It will also check for nested notations (#376 ).
Also added a fixer.