Button customization and state param #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluepnume
reviewed
Mar 30, 2020
src/constants/button.js
Outdated
| @@ -4,8 +4,15 @@ export const BUTTON_LABEL = { | |||
| CONNECT: ('connect' : 'connect') | |||
| }; | |||
|
|
|||
| export const BUTTON_FUNDING_TYPE = { | |||
There was a problem hiding this comment.
Can you use FUNDING from @paypal/sdk-constants/src
bluepnume
reviewed
Mar 30, 2020
| BLUE: ('blue' : 'blue') | ||
| GOLD: ('gold' : 'gold'), | ||
| BLUE: ('blue' : 'blue'), | ||
| DARKBLUE: ('darkblue' : 'darkblue') |
There was a problem hiding this comment.
Can we make sure that:
- Gold and blue are only usable by paypal button
- Dark blue is only usable by credit button
To make sure we're aligning with brand
bluepnume
reviewed
Mar 30, 2020
test/screenshot/config.js
Outdated
| ...DEFAULT_OAUTH_PROPS | ||
| ...DEFAULT_OAUTH_PROPS, | ||
| style: { | ||
| ...(fundingSource === FUNDING.CREDIT ? { color: BUTTON_COLOR.DARKBLUE } : {}) |
There was a problem hiding this comment.
We should default to darkblue if the funding source is credit, without the merchant needing to pass it explicitly.
ravikanthreddy89
force-pushed
the
develop
branch
from
289bba7 to
e144bea
Compare
ravikanthreddy89
changed the title
bluepnume
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list