Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.05] linter: allow options elements in data params #14572

Merged

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Sep 6, 2022

Linting of valid childs for params has been added here: #12232, but options for data params has been forgotten.

In addition also checks for valid attribs and filter types has been added to linting.

Questions:

  • why are tools like tools/maf/interval2maf.xml not linted by the CI?

TODO

  • options_filter_attribute seems allowed
  • check if this is still true
    # only the special case key='build' of type='data_meta' is
    .. example (interval2maf suggests that also other metadata works)
  • maybe doc better alternative
    <validator type="dataset_metadata_in_range" metadata_name="sequences" min="2"/>
    • seems that filtering for a fixed set of metadata values is possible as well with a validator
    • but filtering for a metadata value of another input parameter is not at the moment .. maybe we should extend the validator in this respect?

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@github-actions github-actions bot added this to the 22.09 milestone Sep 6, 2022
@bernt-matthias bernt-matthias force-pushed the topic/lint-data-options branch 2 times, most recently from 2a4ca1a to a5c2eb8 Compare September 6, 2022 13:14
@bernt-matthias bernt-matthias force-pushed the topic/lint-data-options branch 2 times, most recently from 7ae1de4 to 6ebfa1c Compare September 18, 2022 12:38
linting of valid childs for params has been added here:
galaxyproject#12232

options for data params has been forgotten

in addition also checks for valid attribs and filter types
has been added to linting
@bernt-matthias bernt-matthias changed the title linter: allow options elements in data params [22.05] linter: allow options elements in data params Sep 19, 2022
bernt-matthias and others added 2 commits January 30, 2023 11:26
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
@mvdbeek mvdbeek merged commit ca1d2f5 into galaxyproject:release_22.05 Jan 30, 2023
@galaxyproject galaxyproject deleted a comment from github-actions bot Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants