-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[22.05] linter: allow options elements in data params #14572
Merged
mvdbeek
merged 5 commits into
galaxyproject:release_22.05
from
bernt-matthias:topic/lint-data-options
Jan 30, 2023
Merged
[22.05] linter: allow options elements in data params #14572
mvdbeek
merged 5 commits into
galaxyproject:release_22.05
from
bernt-matthias:topic/lint-data-options
Jan 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
force-pushed
the
topic/lint-data-options
branch
2 times, most recently
from
September 6, 2022 13:14
2a4ca1a
to
a5c2eb8
Compare
bernt-matthias
force-pushed
the
topic/lint-data-options
branch
2 times, most recently
from
September 18, 2022 12:38
7ae1de4
to
6ebfa1c
Compare
linting of valid childs for params has been added here: galaxyproject#12232 options for data params has been forgotten in addition also checks for valid attribs and filter types has been added to linting
bernt-matthias
changed the title
linter: allow options elements in data params
[22.05] linter: allow options elements in data params
Sep 19, 2022
4 tasks
mvdbeek
reviewed
Jan 30, 2023
mvdbeek
reviewed
Jan 30, 2023
mvdbeek
approved these changes
Jan 30, 2023
bernt-matthias
commented
Jan 30, 2023
Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting of valid childs for params has been added here: #12232, but options for data params has been forgotten.
In addition also checks for valid attribs and filter types has been added to linting.
Questions:
tools/maf/interval2maf.xml
not linted by the CI?TODO
options_filter_attribute
seems allowedgalaxy/lib/galaxy/tools/parameters/basic.py
Line 1843 in a5c2eb8
galaxy/test/functional/tools/validation_metadata_in_range.xml
Line 7 in a5c2eb8
How to test the changes?
(Select all options that apply)
License