Cleanup Jest Test Output (part 3) #19185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the old code made more sense but the runtime error seems clear and the test still passes and now without Vue yelling about types.
jmchilton
force-pushed
the
testing_24.2_4
branch
from
0f06ae8 to
a705d1f
Compare
|
Selenium test failure unrelated. |
|
https://github.com/galaxyproject/galaxy/actions/runs/11974551776/job/33385876002?pr=19185#step:6:2532 is nothing to worry about ? |
mvdbeek
approved these changes
Nov 22, 2024
I mean it is something to worry about but I think this PR is helping the problem not making it worse. I think you see that a lot in the busier logs prior to these PRs also. The last commit of #19186 might fix it or resolving #19179 might fix it. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on and continues the work of #19178.
How to test the changes?
(Select all options that apply)
License