-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Jest Test Output (part 4) #19186
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
The previous mock was not actually preventing that initial fetch against the API to get an openapi schema.
jmchilton
force-pushed
the
testing_24.2_5
branch
from
November 22, 2024 17:17
73c93f7
to
47ce2db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on and continues the work of #19178 / #19185. The benefits are diminishing. I guess the thing here most likely to affect stability is the mocking change to NotificationForm.test.ts - this seems to eliminate a fetch failure message. I don't know why that fetch failure would affect other tests but the error message looks vaguely related and regardless it is better we aren't doing random fetching against localhost services that don't exist.
How to test the changes?
(Select all options that apply)
License