Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Jest Test Output (part 4) #19186

Merged
merged 17 commits into from
Nov 25, 2024
Merged

Conversation

jmchilton
Copy link
Member

@jmchilton jmchilton commented Nov 22, 2024

Builds on and continues the work of #19178 / #19185. The benefits are diminishing. I guess the thing here most likely to affect stability is the mocking change to NotificationForm.test.ts - this seems to eliminate a fetch failure message. I don't know why that fetch failure would affect other tests but the error message looks vaguely related and regardless it is better we aren't doing random fetching against localhost services that don't exist.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton marked this pull request as ready for review November 24, 2024 16:23
@github-actions github-actions bot added this to the 25.0 milestone Nov 24, 2024
@mvdbeek mvdbeek merged commit 2c5cd3b into galaxyproject:dev Nov 25, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants