Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge latest 24.2 into dev. #19290

Merged
merged 29 commits into from
Dec 9, 2024
Merged

Conversation

jmchilton
Copy link
Member

A clean merge - I'll merge the PR after the tests run.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

ElectronicBlueberry and others added 29 commits December 4, 2024 19:14
Add small visual indicator that they can be moved.
Disable the button and make it clear in the message it has to do with empty filters.
How is a shade of green so evocative of a time.
It results in hiding all the data and a scary red messages when the user did literally nothing wrong. I think this is single biggest issue - it makes it seem like you cannot just manually pair these quickly.
[24.2] Only allow moving activity bar icons when editing the bar.
… a collection

The CollectionCreatorModal.hideModal() function is only called on Cancel or when we explicitly set the prop hideModalOnCreate to true. If we don't set this prop, it leaves the `collectionModalShow` ref set to true as the event to change it to false never gets fired.
This was describing the "selection" mode instructions for the free build from history version - if that makes any sense.
Co-authored-by: Martin Cech <emulatorer@gmail.com>
…ated_build_collection_modal_on_history

[24.2] Fix CollectionCreatorModal being reopened on history
…der_language

[24.2] Fix some collection builder help and language choices.
[24.2] Fix usability of workflow best practice attribute checking.
…low-inputs-activity

[24.2] Workflow Inputs Activity
Co-authored-by: Ahmed Hamid Awan <qe66653@umbc.edu>
[24.2] Fix invocation metrics usability by providing job context.
[24.2] Fix problem with multiple layers in workflow metrics.
…ility

[24.2] Various list of pairs builder usability fixes.
@jmchilton jmchilton added the merge label Dec 9, 2024
@jmchilton jmchilton merged commit 39e38c9 into galaxyproject:dev Dec 9, 2024
55 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants