-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge latest 24.2 into dev. #19290
Merged
Merged
Merge latest 24.2 into dev. #19290
+857
−240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add small visual indicator that they can be moved.
Disable the button and make it clear in the message it has to do with empty filters.
How is a shade of green so evocative of a time.
It results in hiding all the data and a scary red messages when the user did literally nothing wrong. I think this is single biggest issue - it makes it seem like you cannot just manually pair these quickly.
[24.2] Only allow moving activity bar icons when editing the bar.
… a collection The CollectionCreatorModal.hideModal() function is only called on Cancel or when we explicitly set the prop hideModalOnCreate to true. If we don't set this prop, it leaves the `collectionModalShow` ref set to true as the event to change it to false never gets fired.
This was describing the "selection" mode instructions for the free build from history version - if that makes any sense.
Co-authored-by: Martin Cech <emulatorer@gmail.com>
…ated_build_collection_modal_on_history [24.2] Fix CollectionCreatorModal being reopened on history
…der_language [24.2] Fix some collection builder help and language choices.
[24.2] Fix usability of workflow best practice attribute checking.
…low-inputs-activity [24.2] Workflow Inputs Activity
Co-authored-by: Ahmed Hamid Awan <qe66653@umbc.edu>
[24.2] Fix invocation metrics usability by providing job context.
[24.2] Fix problem with multiple layers in workflow metrics.
…ility [24.2] Various list of pairs builder usability fixes.
github-actions
bot
added
area/testing
area/API
area/workflows
area/testing/selenium
area/client
labels
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A clean merge - I'll merge the PR after the tests run.
How to test the changes?
(Select all options that apply)
License