add planemo lint error/warn level parameters #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
added a commit
to bernt-matthias/galaxy-tool-repository-template
that referenced
this pull request
Sep 20, 2021
as introduced here galaxyproject/planemo-ci-action#23
This was referenced Sep 20, 2021
bernt-matthias
force-pushed
the
topic/lint_levels
branch
from
5d17764 to
030c970
Compare
bernt-matthias
added a commit
to bernt-matthias/galaxy-tool-repository-template
that referenced
this pull request
Sep 20, 2021
as introduced here galaxyproject/planemo-ci-action#23
bernt-matthias
force-pushed
the
topic/lint_levels
branch
from
030c970 to
028071e
Compare
and set stricter defaults
bernt-matthias
added a commit
to bernt-matthias/iwc
that referenced
this pull request
Sep 21, 2021
values are the defaults that will be introduced in galaxyproject/planemo-ci-action#23 but I think its a good idea to add them here anyway .. just in case anyone uses the repo as template. fail level warn will be more strict that before, but I guess this is a good idea
mvdbeek
reviewed
Sep 23, 2021
README.md
Outdated
| Optional inputs: | ||
|
|
||
| - `report_level`: all|warn|error (default: all) | ||
| - `fail_level`: warn|error (default: warn) |
There was a problem hiding this comment.
I think the default should be error. If there are instances that are clearly bugs we should elevate them in the linter to error.
There was a problem hiding this comment.
My rationale was that warnings correspond to violations of best practices which we usually do not want. But we can also do this per repo (I would definitely suggest this for the IUC).
|
@mvdbeek this should be good to go. |
5 tasks
5 tasks
mvdbeek
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and set stricter defaults