replace @VERSION@ with @TOOL_VERSION@ in gff_prot wrapper

[cat-bro]

As part of Galaxy Australia's updates we have install gff_prot with version "@Version@+galaxy0". This is because in the macros the token has changed to @TOOL_VERSION. This is the only instance of @Version@ I could find in the /transit/ directory

FOR CONTRIBUTOR:

• - I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
• - License permits unrestricted use (educational + commercial)
• - This PR adds a new tool or tool collection
• - This PR updates an existing tool or tool collection
• - This PR does something else (explain below)

[bernt-matthias]

@cat-bro do you have the link to the PR that changed this? I would like to know why CI did not fail.

[cat-bro]

@bernt-matthias #4223

[nsoranzo]

In fact the CI found it but it's a warning:

Applying linter xml_order... WARNING
.. WARNING: Best practice violation [macros] elements should come before [xrefs]
Linting repository /home/runner/work/tools-iuc/tools-iuc/tools/transit
+Linting tool /home/runner/work/tools-iuc/tools-iuc/tools/transit/convert_gff.xml
Applying linter xml_order... WARNING
.. WARNING: Best practice violation [macros] elements should come before [xrefs]
Applying linter general... WARNING
.. WARNING: Tool version [@VERSION@+galaxy0] is not compliant with PEP 440.
Linting repository /home/runner/work/tools-iuc/tools-iuc/tools/transit
+Linting tool /home/runner/work/tools-iuc/tools-iuc/tools/transit/transit_gumbel.xml
Applying linter xml_order... WARNING
.. WARNING: Best practice violation [macros] elements should come before [xrefs]
Linting repository /home/runner/work/tools-iuc/tools-iuc/tools/transit
+Linting tool /home/runner/work/tools-iuc/tools-iuc/tools/transit/transit_resampling.xml
Applying linter xml_order... WARNING
.. WARNING: Best practice violation [macros] elements should come before [xrefs]
Linting repository /home/runner/work/tools-iuc/tools-iuc/tools/transit
+Linting tool /home/runner/work/tools-iuc/tools-iuc/tools/transit/transit_hmm.xml
Applying linter xml_order... WARNING
.. WARNING: Best practice violation [macros] elements should come before [xrefs]

[bernt-matthias]

Thanks for looking this up @nsoranzo

Maybe these will help in the future galaxyproject/planemo-ci-action#23 galaxyproject/galaxy-tool-repository-template#8

But I'm a bit worried that setting the fail level to warn might make to much noise...