Electron 3,4,5 pre builts by add libpng function prefixes #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prefixing added in version 1.6 of libpng does solve the version conflict of electrons libpng 1.2 and pdfwriter 1.6 by prefixing the exported functions and used functions of pdfwriter.
This was referenced Jul 23, 2019
…amic linked libraries.
julianhille
changed the title
|
some mixup in my travis setup due to org->com change. i'll review and merge...just want to run some tests. |
|
Great thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prefixing added in version 1.6 of libpng does solve
the version conflict of electrons libpng 1.2 and pdfwriter 1.6 by prefixing
the exported functions and used functions of pdfwriter.
This also adds some more minor electron version together with xvfb fixes and streamlining of electron tests.
Electron 2.0.x might have never worked for dfonts cause it was tested against the node / nvm version instead of electron.
I created #411 and excluded 2.0.x from pre built binaries as they do not pass tests.