manualExit suppresses -quit, useful for buildMethods with async calls

[tobyspark]

Changes

• Adds with: manualExit parameter to the action, that when present suppresses the Unity -quit command line argument. See Add config flag that drops -quit from builder cli#13 and Configuration option to suppress -quit #442

Checklist

• Read the contribution guide and accept the
  code of conduct
• Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make
  a PR in the documentation repo)
• Readme (updated or not needed)
• Tests (added, updated or not needed)

[github-actions]

[tobyspark]

Notes

• ubuntu only so far. What else would need to be done?
• seems manualExit should be a boolean that defaults to false, but I didn’t see an example of that? Currently build.sh works on the presence of the env var, but the javascript requires a string for it to be passed through.

[webbertakken]

Looks good to me, mostly.

[webbertakken]

Currently you're passing the variable directly to the bash script and doing complicated logic (I believe this is the first time we use +set in this repo) that differs from other is set checks in our bash scripts.

We want to move as much away from the bash scripts as possible (in favour of the higher level TypeScript code) and not pass arbitrary values to it. Normalisation and input should either be guaranteed to be correct or throw an error so that the user knows they've misconfigured something.

Should this default to false?

[tobyspark]

It should default to false. Having it be the presence of a value wasn’t what I wanted, but was a first pass at using what I found; e.g. I didn’t see an example of boolean handling; Input.getInput returns a string. Happy to be pointed in the right direction.

Similarly, the bash script responds to the presence or not of the env var, which is clean from the POV of the separation of parsing the input. But I have no love for this kind of scripting and am happy to be pointed in the direction of how this this effect is achieved elsewhere in the codebase.

[webbertakken]

I'm in a bit of a hurry atm, but basically consider workflow inputs as input for the TS logic, and the TS logic to be responsible for passing in something deterministic to the bash script.

Ideally we'd remove the string | undefined in favour of string like the rest does, and parse that into a true or false or 1 or 0 value, and pass that into the script.

[tobyspark]

Now models input as a boolean. I can squash the commit if that’s desired.

Reminder – haven’t touched the other platforms.

[codecov-commenter]

Codecov Report

Merging #574 (8c6914b) into main (2190fd5) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 8c6914b differs from pull request most recent head aab7c4f. Consider uploading reports for the commit aab7c4f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #574      +/-   ##
==========================================
+ Coverage   36.96%   37.02%   +0.06%     
==========================================
  Files          77       77              
  Lines        3038     3041       +3     
  Branches      641      632       -9     
==========================================
+ Hits         1123     1126       +3     
+ Misses       1915     1765     -150     
- Partials        0      150     +150     

Files Changed	Coverage Δ
src/model/build-parameters.ts	89.39% <ø> (ø)
src/model/image-environment-factory.ts	7.14% <ø> (ø)
src/model/input.ts	90.98% <100.00%> (+0.22%)	⬆️

... and 36 files with indirect coverage changes

[webbertakken]

This'll also need to be documented in https://github.com/game-ci/documentation

[GabLeRoux]

nice