Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'enableGpu' param, allowing running Unity w/o -nographics #636

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

codenamesimon
Copy link
Contributor

Changes

  • Similarly to -manualExit allows to disable -nographics for macOS build invocation
  • Purpose of this is to run the builder on gpu-enabled machines that use GPU during build process

Related PRs

Successful Workflow Run Link

Validated inside org repository.

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

Copy link

github-actions bot commented Mar 7, 2024

Cat Gif

Copy link
Member

@webbertakken webbertakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

LGTM.

Can you confirm this works on your fork?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.99%. Comparing base (e820c9c) to head (76ec478).

❗ Current head 76ec478 differs from pull request most recent head e1a2483. Consider uploading reports for the commit e1a2483 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   36.93%   36.99%   +0.06%     
==========================================
  Files          77       77              
  Lines        3119     3122       +3     
  Branches      608      609       +1     
==========================================
+ Hits         1152     1155       +3     
  Misses       1967     1967              
Files Coverage Δ
src/model/build-parameters.ts 90.00% <ø> (ø)
src/model/image-environment-factory.ts 4.00% <ø> (ø)
src/model/input.ts 88.81% <100.00%> (+0.22%) ⬆️

@codenamesimon
Copy link
Contributor Author

Yes, the command line argument is properly stripped:

Launching external process: /Applications/Unity/Hub/Editor/2021.3.29f1/Unity.app/Contents/Resources/PackageManager/Server/UnityPackageManager

COMMAND LINE ARGUMENTS:
/Applications/Unity/Hub/Editor/2021.3.29f1/Unity.app/Contents/MacOS/Unity
-logFile
-
-quit
-batchmode
-username
***
-password
(hidden)
-customBuildName
appBundle
... etc etc

@webbertakken
Copy link
Member

Cool. Will merge it. Would you mind still addressing point 2 from the checklist, please?

@webbertakken webbertakken merged commit fc0a52b into game-ci:main Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants