Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry-cache-unit-tests: Use make verify-extended and reduce resouces #725

Merged
merged 2 commits into from
May 11, 2023

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented May 11, 2023

/kind enhancement

What this PR does / why we need it:
This PR adapts the registry-cache-unit-tests jobs in a way inspired by shoot-oidc-service jobs: https://github.com/gardener/ci-infra/blob/7a666e61f199138480e8dc2c5f28072801f27016/config/jobs/extension-shoot-oidc-service/extension-shoot-oidc-service-unit-tests.yaml

Which issue(s) this PR fixes:
Part of gardener/gardener-extension-registry-cache#3

Special notes for your reviewer:
N/A

@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 11, 2023
@gardener-prow gardener-prow bot requested review from timebertt and timuthy May 11, 2023 12:38
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 11, 2023
@oliver-goetz
Copy link
Member

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2023
@gardener-prow
Copy link

gardener-prow bot commented May 11, 2023

LGTM label has been added.

Git tree hash: b48e3e1d9943f1ba9d773513cffc95a5c9eb0237

@gardener-prow
Copy link

gardener-prow bot commented May 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@gardener-prow gardener-prow bot merged commit 0dd4135 into gardener:master May 11, 2023
@gardener-prow
Copy link

gardener-prow bot commented May 11, 2023

@ialidzhikov: Updated the job-config configmap in namespace prow at cluster gardener-prow-trusted using the following files:

  • key gardener-extension-registry-cache-unit-tests.yaml using file config/jobs/gardener-extension-registry-cache/gardener-extension-registry-cache-unit-tests.yaml

In response to this:

/kind enhancement

What this PR does / why we need it:
This PR adapts the registry-cache-unit-tests jobs in a way inspired by shoot-oidc-service jobs: https://github.com/gardener/ci-infra/blob/7a666e61f199138480e8dc2c5f28072801f27016/config/jobs/extension-shoot-oidc-service/extension-shoot-oidc-service-unit-tests.yaml

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ialidzhikov ialidzhikov deleted the enh/registry-cache-unit branch May 11, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants