-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting gardener-extension-registry-cache production ready #3
Comments
Seems to be a reasonable list. However, I am wondering whether we could just release a v0.0.1 before. Then we (23T) could easily include the extension in our public gardener installation and just see how the current state and further developments behave in a running environment. Any comments on that? |
Would you like to release the v0.0.1 @oliver-goetz? Actually, I am not entirely sure how what kind of release workflow is intended for this repo. |
@JensAc sorry I missed your question 😅 |
gardener/gardener#6999 is merged now which (I think) was the prerequisite to follow the "webhook approach" :) |
@JensAc finally, there is the first release 😄 |
Nice! Many thanks 👍 |
Considering the points in gardener/gardener#7316, this extension should not make use of the containerd imports feature. |
All sub-tasks are completed. /close |
@dimitar-kostadinov: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
How to categorize this issue?
/area quality cost
/kind task
What would you like to be added:
At the end of our Hackathon we had some tasks on your list in order to make the registry-cache production ready.
Why is this needed:
Getting the registry-cache extension production ready.
Steps
/etc/containerd/cert.d/
: Refactor the extension using a webhook for OperatingSystemConfigs to add containerd hosts.toml files #27OperatingSystemConfig
afterExtension
resources gardener#8232config_path
: Introduce theContainerdRegistryHostsDir
feature gate gardener#8094Modify the default containerd config in gardener to specify
ContainerdRegistryHostsDir
feature gate to GA. Clean up the feature gateContainerdRegistryHostsDir
feature gate to beta gardener#8873ContainerdRegistryHostsDir
feature gate to GA gardener#8979ContainerdRegistryHostsDir
feature gate gardener#9058ContainerdRegistryHostsDir
feature gate (part 1) gardener#8441/etc/containerd/cert.d/
) do not require restart of containerd./etc/containerd/conf.d/
imported files is flawed and doesn't work for all cases: https://github.com/gardener/gardener/blob/master/docs/usage/custom-containerd-config.md / Local Provider: Fix containerd configuration for registry mirrors gardener#7316 / config merge via imports overwrites the wrong part of the config containerd/containerd#5837. That's why we cannot use the custom containerd config import functionality for now.Node machines cannot resolve the DNS names of the registry cache services yet. Currently, containerd config includes IP addresses of the registry cache pods/services. Find a way to make this DNS resolution work.make extension-down
and rework skaffold handling to also deploy the registry-cache admission duringmake extension-up
: Improve the skaffold setup of the extension. Fixmake extension-down
#40ttl
and remove the existing option to enable/disable the garbage collection. Consider forbiddingttl < 24h
asttl=0
can mean that image never gets garbage collected (double check this).garbageCollection.enabled
field in favor of thegarbageCollection.ttl
field.garbageCollectionEnabled
field togarbageCollection.enabled
. This is to make possible adding new fields related to the garbage collection in future (thettl
field): Change thegarbageCollectionEnabled
field togarbageCollection.enabled
#53/metrics
endpoint that is prometheus native formatregistry-cache
orkube-system
. The control plane monitoring currently does not monitor workload from theregistry-cache
namespace (i.e. we don't have metrics for Pod cpu/memory usage; logs are not collected): Usekube-system
namespace to deploy registry cache extension #52initialize counters: Initialize proxy prometheus counters values to 0 distribution/distribution#4283
ContainerdRegistryHostsDir
feature gate gardener#8094Cleaning Kubernetes resources
deletes the registry-cache resources which are recreated by GRM in few moments: Prevent gardenlet to delete registry-cache resources on Shoot deletion #25no persistent volumes available for this claim and no storage class is set
: Explicitly set the PVC'sstorageClassName
todefault
#51--version
command: Fix the--version
flag #98make extension-up
in provider-extensions setup @dimitar-kostadinov Introduceremote-extension-up
make target #193images.yaml
file: skaffold: Rebuild when there are changes togo:embed
files #57shoot
namespace inseed
for health check except one having class seed gardener#7462 gardenlet checks for all ManagedResources in the Shoot control plane. We don't need anymore the healthcheck controller: Drop the healthcheck controller #32priorityClassName
for the registry cache Pods #47Check Pulls take a long time to complete when the repository mirror endpoint is timing out containerd/containerd#4861 and see whether with docker there are timeouts of 30 seconds/test pull-gardener-publish-test-images
command for the registry-cache repo so that it is possible to publish images from PRs: Add publish-test-images job to the registry-cache extension ci-infra#970imageVectorOverwrite
so that it is possible to pass it as YAML, not as a single line string: Change the imageVectorOverwrite value type from string to object #80v1alpha1
API version: Remove the v1alpha1 API #141v1alpha2
API version only: Clean up v1alpha1 usages from tests #140proxy.ttl=0
toproxy.ttl > 0
leaks blobs that never get garbage collected distribution/distribution#4249: Forbid GC enablement once it is disabled #131configure-containerd-registries.service
unit by using another retry strategy in the unit other than exponential backoff: Improveconfigure-containerd-registries
unit retry strategy #137v1alpha2
API version: Remove the v1alpha2 API #165v1alpha3
API version only: Clean up v1alpha2 usages #151http://
and port (optional): IntroduceremoteURL
field in RegistryCache API #183scheduler-state.json
file Rework image pull check in E2E tests #196The text was updated successfully, but these errors were encountered: