Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monitoring dashboard for registry cache persistent volumes #112

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Add monitoring dashboard for registry cache persistent volumes #112

merged 3 commits into from
Dec 19, 2023

Conversation

dimitar-kostadinov
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov commented Dec 13, 2023 •
edited by ialidzhikov
Loading

How to categorize this PR?

/area monitoring
/kind enhancement

What this PR does / why we need it:
Add monitoring dashboard for registry cache persistent volumes

Which issue(s) this PR fixes:
Part of #3

Special notes for your reviewer:

Release note:

Metrics for registry cache persistent volumes are exposed in the `Registry Caches` plutono dashboard.

@gardener-prow gardener-prow bot added the area/monitoring Monitoring (including availability monitoring and alerting) related label Dec 13, 2023
@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2023
@ialidzhikov
Copy link
Member

/assign

@dimitar-kostadinov dimitar-kostadinov mentioned this pull request Dec 14, 2023
Closed
96 tasks
ialidzhikov
ialidzhikov reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Minor suggestions inline.

pkg/component/registrycaches/monitoring/dashboard.yaml Outdated Show resolved Hide resolved
pkg/component/registrycaches/monitoring.go Outdated Show resolved Hide resolved
pkg/component/registrycaches/monitoring.go Show resolved Hide resolved
pkg/component/registrycaches/monitoring/dashboard.yaml Outdated Show resolved Hide resolved
pkg/component/registrycaches/monitoring/dashboard.yaml Outdated Show resolved Hide resolved
pkg/component/registrycaches/monitoring/dashboard.yaml Outdated Show resolved Hide resolved
ialidzhikov
ialidzhikov approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 19, 2023

LGTM label has been added.

Git tree hash: b953108f889951966020ca3f7dd25174dddf147d

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2023
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 19, 2023

LGTM label has been added.

Git tree hash: f613ed08980f021a7a134303e4d48d4073a7abcf

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot merged commit 374e91f into gardener:main Dec 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

@timebertt timebertt Awaiting requested review from timebertt

Assignees

@ialidzhikov ialidzhikov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring Monitoring (including availability monitoring and alerting) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimitar-kostadinov @ialidzhikov