Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for end users #44

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Add docs for end users #44

merged 1 commit into from
Oct 23, 2023

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:
The PR adds end user documentation.

Which issue(s) this PR fixes:
Part of #3

Special notes for your reviewer:
N/A

Release note:

NONE

@gardener-prow gardener-prow bot added the kind/enhancement Enhancement, improvement, extension label Sep 20, 2023
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2023
@ialidzhikov ialidzhikov mentioned this pull request Sep 20, 2023
Closed
96 tasks
@ialidzhikov ialidzhikov added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2023
@gardener-ci-robot
Copy link

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2023
@ialidzhikov ialidzhikov removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2023
@ialidzhikov ialidzhikov force-pushed the enh/docs branch 3 times, most recently from aff3a12 to 4a3c559 Compare October 17, 2023 06:58
@ialidzhikov ialidzhikov changed the title Add docs Add docs for end users Oct 17, 2023
@ialidzhikov
Copy link
Member Author 

Error: INSTALLATION FAILED: 1 error occurred:
	* Internal error occurred: failed calling webhook "clusterrole-machine-controller-manager.local.extensions.gardener.cloud": failed to call webhook: Post "[https://gardener-extension-provider-local.extension-provider-local-x2zqt.svc:443/clusterrole-machine-controller-manager?timeout=5s](https://gardener-extension-provider-local.extension-provider-local-x2zqt.svc/clusterrole-machine-controller-manager?timeout=5s)": dial tcp 10.2.26.120:443: connect: connection refused
deploying "gardener-extension-registry-cache-admission": install: exit status 1

/test pull-gardener-extension-registry-cache-e2e-kind

@ialidzhikov
Copy link
Member Author

/hold cancel

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2023
dimitar-kostadinov
dimitar-kostadinov approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 20, 2023

LGTM label has been added.

Git tree hash: df0fb64e10d1cd60de8521bf74c08d3f31e57a74

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dimitar-kostadinov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@ialidzhikov
Copy link
Member Author

/hold
I wanted to amend 1 small thing

@gardener-prow gardener-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2023
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@ialidzhikov
Copy link
Member Author

/hold cancel

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2023
dimitar-kostadinov
dimitar-kostadinov reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Oct 23, 2023

LGTM label has been added.

Git tree hash: aa2530fd1e161370ee298e66e168d1ecbc5927a9

@gardener-prow gardener-prow bot merged commit 2c340c1 into gardener:main Oct 23, 2023
6 checks passed
@ialidzhikov ialidzhikov deleted the enh/docs branch October 24, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@istvanballok istvanballok istvanballok left review comments

@dimitar-kostadinov dimitar-kostadinov dimitar-kostadinov approved these changes

@Kostov6 Kostov6 Awaiting requested review from Kostov6

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

Assignees

@dimitar-kostadinov dimitar-kostadinov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ialidzhikov @gardener-ci-robot @istvanballok @dimitar-kostadinov