Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce remote-extension-up make target #193

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Introduce remote-extension-up make target #193

merged 3 commits into from
Jun 3, 2024

Conversation

dimitar-kostadinov
Copy link
Contributor

@dimitar-kostadinov dimitar-kostadinov commented May 9, 2024 •
edited by ialidzhikov
Loading

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:
Introduces remote-extension-up make target to support development environment in provider-extensions setup.

Which issue(s) this PR fixes:
Part of #3

Special notes for your reviewer:
Depends on gardener/gardener#9728

Release note:

The registry-cache extension does now support the [Deploying Gardener Locally and Enabling Provider-Extensions](https://github.com/gardener/gardener/blob/v1.85.1/docs/deployment/getting_started_locally_with_extensions.md) local setup.

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension labels May 9, 2024
@gardener-prow gardener-prow bot requested a review from ialidzhikov May 9, 2024 12:38
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2024
@dimitar-kostadinov dimitar-kostadinov mentioned this pull request May 9, 2024
Closed
96 tasks
@dimitar-kostadinov dimitar-kostadinov force-pushed the enh/extension-up-in-provider-extensions-setup branch from 13b136d to 5ebf21e Compare May 9, 2024 13:48
@dimitar-kostadinov dimitar-kostadinov marked this pull request as ready for review May 9, 2024 13:53
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 9, 2024
@dimitar-kostadinov dimitar-kostadinov force-pushed the enh/extension-up-in-provider-extensions-setup branch from 5ebf21e to 8a1452f Compare May 10, 2024 06:18
plkokanov
plkokanov suggested changes May 13, 2024
View reviewed changes
Copy link

@plkokanov plkokanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few nits on my side.

hack/remote-extension-up.sh Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
hack/remote-extension-up.sh Outdated Show resolved Hide resolved
@plkokanov plkokanov mentioned this pull request May 13, 2024
Merged
@plkokanov plkokanov mentioned this pull request May 17, 2024
Merged
@plkokanov
Copy link

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
@dimitar-kostadinov dimitar-kostadinov added area/ipcei IPCEI (Important Project of Common European Interest) ipcei/registry-cache-extension Registry Cache Extension labels May 21, 2024
timebertt
timebertt reviewed May 23, 2024
View reviewed changes
skaffold.yaml Outdated Show resolved Hide resolved
@ialidzhikov
Copy link
Member

/assign

@ialidzhikov ialidzhikov changed the title Introduce remote-extension-up make target. Introduce remote-extension-up make target May 27, 2024
ialidzhikov
ialidzhikov requested changes May 27, 2024
View reviewed changes
docs/development/getting-started-remotely.md Show resolved Hide resolved
docs/development/getting-started-remotely.md Outdated Show resolved Hide resolved
skaffold.yaml Show resolved Hide resolved
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
@gardener-prow gardener-prow bot requested a review from ialidzhikov May 27, 2024 08:29
@gardener-prow gardener-prow bot requested a review from plkokanov May 27, 2024 08:29
ialidzhikov
ialidzhikov reviewed May 27, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from @timebertt 's comment, lgtm. I tested locally 🚀

Makefile Show resolved Hide resolved
docs/development/getting-started-remotely.md Outdated Show resolved Hide resolved
docs/development/getting-started-remotely.md Outdated Show resolved Hide resolved
skaffold.yaml Show resolved Hide resolved
ialidzhikov
ialidzhikov reviewed May 29, 2024
View reviewed changes
Makefile Show resolved Hide resolved
ialidzhikov
ialidzhikov reviewed May 30, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@dimitar-kostadinov dimitar-kostadinov force-pushed the enh/extension-up-in-provider-extensions-setup branch from 151c512 to 0242067 Compare June 3, 2024 06:15
ialidzhikov
ialidzhikov approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jun 3, 2024

LGTM label has been added.

Git tree hash: 0eaac6f89d2c7c37243ebe1fe3465de08cd3b0c7

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
@gardener-prow gardener-prow bot merged commit e6ba9b7 into gardener:main Jun 3, 2024
6 checks passed
@plkokanov plkokanov mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timebertt timebertt timebertt left review comments

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@plkokanov plkokanov Awaiting requested review from plkokanov

Assignees

@ialidzhikov ialidzhikov

@plkokanov plkokanov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) area/ipcei IPCEI (Important Project of Common European Interest) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. ipcei/registry-cache-extension Registry Cache Extension kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dimitar-kostadinov @plkokanov @ialidzhikov @timebertt