Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce remote-extension-up make target #102

Conversation

plkokanov
Copy link
Collaborator

@plkokanov plkokanov commented May 13, 2024

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:
Introduces remote-extension-up make target to support development environment in provider-extensions setup
Additionally it introduces a configure-shoot make target, to make it easier to deploy an rsyslog relp echo server and configure the extension so that logs from the Shoot nodes are forward to this echo server.

Which issue(s) this PR fixes:
Part of #2

Special notes for your reviewer:
Similar to gardener/gardener-extension-registry-cache#193

Release note:

NONE

Copy link

gardener-prow bot commented May 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension labels May 13, 2024
@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 13, 2024
@gardener-prow gardener-prow bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels May 13, 2024
@plkokanov plkokanov force-pushed the enh/support-gardener-setup-with-extensions branch from 2214387 to c7b6755 Compare May 13, 2024 14:05
@plkokanov plkokanov marked this pull request as ready for review May 13, 2024 14:09
@gardener-prow gardener-prow bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 13, 2024
Copy link

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

docs/development/getting-started-remotely.md Outdated Show resolved Hide resolved
@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
Copy link

gardener-prow bot commented May 20, 2024

LGTM label has been added.

Git tree hash: 715fe48b7c4b840a55810468593ebff55884d4b0

@plkokanov plkokanov force-pushed the enh/support-gardener-setup-with-extensions branch from 7fa6c19 to 8da48a2 Compare May 21, 2024 12:34
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2024
Copy link

@dimitar-kostadinov dimitar-kostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
Copy link

gardener-prow bot commented May 21, 2024

LGTM label has been added.

Git tree hash: 73927895e04d312a951dc5197e3cef62c6b305e0

@plkokanov
Copy link
Collaborator Author

/approve

Copy link

gardener-prow bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: plkokanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@gardener-prow gardener-prow bot merged commit b378da4 into gardener:main May 21, 2024
7 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants