Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cri-config-ensurer and registry images #23

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Jul 23, 2023

How to categorize this PR?

/area quality
/kind regression
/kind bug

What this PR does / why we need it:
Currently the cri-config-ensurer has the following code for the image:

Note that it uses only the repository and ignores any tag.

This results in the Pod to be created such as:

  containers:
  - name: name: cri-config-ensurer
    image: eu.gcr.io/gardener-project/3rd/bash

After #17, the repo is switched to eu.gcr.io/gardener-project/3rd/bash and the latest tag does no longer exists. Hence, currently the cri-config-ensurer cannot be pulled at all:

% k -n registry-cache get po
NAME                       READY   STATUS             RESTARTS   AGE
cri-config-ensurer-xs7l6   0/1     ImagePullBackOff   0          43m
  Warning  Failed     13m (x3 over 14m)     kubelet            Failed to pull image "eu.gcr.io/gardener-project/3rd/bash": rpc error: code = NotFound desc = failed to pull and unpack image "eu.gcr.io/gardener-project/3rd/bash:latest": failed to resolve reference "eu.gcr.io/gardener-project/3rd/bash:latest": eu.gcr.io/gardener-project/3rd/bash:latest: not found

The same applies for the registry image:

  Warning  Failed            6s                   kubelet            Failed to pull image "eu.gcr.io/gardener-project/3rd/registry": rpc error: code = NotFound desc = failed to pull and unpack image "eu.gcr.io/gardener-project/3rd/registry:latest": failed to resolve reference "eu.gcr.io/gardener-project/3rd/registry:latest": eu.gcr.io/gardener-project/3rd/registry:latest: not found

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:
N/A

Release note:

NONE

@gardener-prow gardener-prow bot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution kind/bug Bug cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jul 23, 2023
@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2023
@ialidzhikov ialidzhikov changed the title Fix cri-config-ensurer image Fix cri-config-ensurer and registry images Jul 23, 2023
@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2023
@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow
Copy link
Contributor

gardener-prow bot commented Jul 24, 2023

LGTM label has been added.

Git tree hash: 9daeb9cc6a914fce8d5c0a2d01680c51a2b9954e

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2023
@gardener-prow gardener-prow bot merged commit 15fe2ea into gardener:main Jul 24, 2023
1 check passed
@ialidzhikov ialidzhikov deleted the fix/cri-config-ensurer-image branch July 24, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug kind/regression Bug that hit us already in the past and that is reappearing/requires a proper solution lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants