Add e2e tests #30
Merged
Add e2e tests #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
area/testing
gardener-prow
bot
added
the
size/XXL
96 tasks
ialidzhikov
force-pushed
the
enh/e2e-tests
branch
2 times, most recently
from
989d79f
to
74cf72b
Compare
gardener-prow
bot
added
the
needs-rebase
`make extension-up` fails with: ``` Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: resource mapping not found for name: "gardener-extension-registry-cache-admission" namespace: "garden" from "": no matches for kind "PodDisruptionBudget" in version "policy/v1beta1" ```
It seems to work also without the `https://` prefix but to be aligned with the upstream docs/examples (ref https://github.com/containerd/containerd/blob/main/docs/hosts.md) and provider-local (ref https://github.com/gardener/gardener/blob/v1.77.0/pkg/provider-local/webhook/controlplane/ensurer.go#L167-L174) I decided to add the prefix for the registry-cache as well.
ialidzhikov
force-pushed
the
enh/e2e-tests
branch
from
74cf72b
to
6eff72b
Compare
gardener-prow
bot
removed
the
needs-rebase
ialidzhikov
force-pushed
the
enh/e2e-tests
branch
from
6eff72b
to
e59b7bf
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
ialidzhikov
force-pushed
the
enh/e2e-tests
branch
from
e59b7bf
to
43d38c2
Compare
|
LGTM label has been added. Git tree hash: 743cf1a36fd4ec70f1714f0a49347fe5d91fd05e
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area testing
/kind enhancement
What this PR does / why we need it:
This PR adds 2 e2e tests. The plan forward is to execute these e2e tests in prow on PR.
The added e2e tests:
Which issue(s) this PR fixes:
Part of #3
Special notes for your reviewer:
N/A
Release note: