Kubernetes Version Configurability per Worker Pool #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/usability
gardener-robot
added
the
size/m
gardener-robot-ci-2
added
reviewed/ok-to-test
rfranzke
force-pushed
the
enh/kubeletversion
branch
from
f478691
to
c26aa64
Compare
gardener-robot
added
size/s
gardener-robot-ci-1
added
the
reviewed/ok-to-test
|
/ready |
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
|
/invite @jia-jerry @EmoinLanyu |
|
@EmoinLanyu, @jia-jerry You have pull request review open invite, please check |
rfranzke
force-pushed
the
enh/kubeletversion
branch
from
c26aa64
to
c8d8b3e
Compare
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
|
/test |
|
Testrun: e2e-hmgsx +---------------------+---------------------+--------+----------+ | NAME | STEP | PHASE | DURATION | +---------------------+---------------------+--------+----------+ | infrastructure-test | infrastructure-test | Failed | 4m12s | +---------------------+---------------------+--------+----------+ |
|
Why did this test fail? I can't find any logs 👀 @dguendisch @hendrikKahl |
The node where the testrun's pod has been scheduled seems to be unhealthy. Promtail get's OOM-killed frequently (though there seems to be no memory pressure) and kubelet is reporting a failure to garbage collect images leading to disk pressure. |
|
OK, unrelated to this PR then. Anyways, the infrastructure test or anything related to it is not touched with this PR. @EmoinLanyu Can we proceed? |
Yes. Infra test is not related, we can proceed. |
|
/lgtm |
gardener-robot
added
reviewed/lgtm
EmoinLanyu
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area usability
/kind enhancement
/platform vsphere
/merge squash
What this PR does / why we need it:
This PR implements support for
gardener/gardener'sWorkerPoolKubernetesVersionfeature gate. Since there is no CSI migration, the only task was adapting thecontrolpanewebhook to use the effective kubelet version when computing the CSI migration feature gates.Which issue(s) this PR fixes:
Part of gardener/gardener#3501
Special notes for your reviewer:
✅
Depends on #422, hence, PR is in draft state.Release note:
This extension does now support `gardener/gardener`'s `WorkerPoolKubernetesVersion` feature gate, i.e., having [worker pools with overridden Kubernetes versions](https://github.com/gardener/gardener/blob/8a9c88866ec5fce59b5acf57d4227eeeb73669d7/example/90-shoot.yaml#L69-L70).