Integrate ocm lib only #837

achimweigel · 2023-09-29T04:36:44Z

How to categorize this PR?

/area deployers
/kind enhancement
/priority 3

What this PR does / why we need it:

This PR adds the main part of files required to integrate the new OCM lib without changing the current productive coding. This allows the review of follow up PRs.

To speed up the build some new coding is commented out. All these part could be found searching for TODO of NotImplemented.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

- integrate OCM files

gardener-prow · 2023-09-29T04:36:48Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

guewa · 2023-10-02T09:18:12Z

/test all

gardener-prow · 2023-10-02T09:18:18Z

@guewa: No jobs can be run with /test all.
The following commands are available to trigger required jobs:

/test pull-landscaper-e2e-kind

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

guewa · 2023-10-02T09:18:39Z

/test pull-landscaper-e2e-kind

gardener-prow · 2023-10-02T09:21:02Z

@achimweigel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-landscaper-e2e-kind	`48b5556`	link	true	`/test pull-landscaper-e2e-kind`

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

guewa

all tests passed

fabianburth

Appears like no active coding was changed.

This reverts commit 918c259.

* fix logging (run-int-tests) (gardener#819) * Performance Config (gardener#818) * Deployer config * Landscaper config * Metrics in Helm Chart Templates and Values (gardener#821) * Metrics * Test (run-int-tests) * Component Library Flag (gardener#822) * Flag for component library * Generate * Pass component library flag to subobjects * Default component library * Generate * Mark fields as optional (run-int-tests) * Revert "Component Library Flag (gardener#822)" (gardener#824) This reverts commit 63a77b1. * add feedback to proposal (gardener#826) * OCM Flag (gardener#825) * OCM flag in context * OCM flag in landscaper config * Generate * OCM flag in deployer config * Generate (run-int-tests) * Proposal timeouts and typical error page (gardener#823) * timeout proposal * Release v0.78.0 * Prepare next Dev Cycle v0.79.0-dev * update pipeline definition (gardener#829) * fix blueprint docu (gardener#832) * Fix pipeline (gardener#835) * adjust pipeline to run with specific component lib version (run-int-tests) * minor adjustments * (run-int-tests) * update pipeline definition for head updates (gardener#830) * update pipeline definition for head updates * update pipeline for release jobs * fix dependency relationship for update release * Pipeline fix (gardener#836) * fix pipeline * (run-int-tests) * Update .ci/pipeline_definitions Co-authored-by: Johannes Aubart <johannes.aubart@sap.com> --------- Co-authored-by: Johannes Aubart <johannes.aubart@sap.com> * true in pipeline definition converted to True (gardener#839) * Integrate ocm lib only (gardener#837) * ocm-lib-test (run-int-tests) * (run-int-tests) --------- Co-authored-by: Fabian Burth <fabian.burth@sap.com> * USE_OCM_LIB parameter for local int tests (gardener#846) --------- Co-authored-by: achimweigel <achim.weigel@sap.com> Co-authored-by: Robert Gräff <robert.graeff@sap.com> Co-authored-by: gardener-robot-ci-3 <gardener.ci.user3@gmail.com> Co-authored-by: gardener-robot-ci-2 <gardener.ci.user2@gmail.com> Co-authored-by: Fabian Burth <fabian.burth@sap.com> Co-authored-by: Johannes Aubart <johannes.aubart@sap.com>

gardener-robot added area/deployers Deployer related kind/enhancement Enhancement, improvement, extension priority/3 Priority (lower number equals higher priority) needs/review Needs review labels Sep 29, 2023

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 29, 2023

gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Sep 29, 2023

gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 29, 2023

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 29, 2023

gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 29, 2023

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 29, 2023

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 29, 2023

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 29, 2023

achimweigel requested a review from fabianburth September 29, 2023 12:01

guewa added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 2, 2023

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 2, 2023

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 2, 2023

achimweigel and others added 2 commits October 2, 2023 13:07

ocm-lib-test (run-int-tests)

1e121aa

(run-int-tests)

3ddad42

fabianburth force-pushed the integrate-ocm-lib branch from 766b525 to 3ddad42 Compare October 2, 2023 11:09

gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 2, 2023

gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 2, 2023

guewa marked this pull request as ready for review October 2, 2023 12:56

guewa requested a review from a team as a code owner October 2, 2023 12:56

guewa requested a review from robertgraeff October 2, 2023 12:56

guewa added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 2, 2023

guewa approved these changes Oct 2, 2023

View reviewed changes

fabianburth approved these changes Oct 4, 2023

View reviewed changes

achimweigel merged commit 918c259 into gardener:master Oct 4, 2023

gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 4, 2023

fabianburth added a commit that referenced this pull request Oct 4, 2023

Revert "Integrate ocm lib only (#837)"

0925a02

This reverts commit 918c259.

fabianburth mentioned this pull request Oct 4, 2023

Revert "Integrate ocm lib only " #843

Closed

fabianburth mentioned this pull request Oct 27, 2023

ocm-lib facade implementation #756

Closed

fabianburth mentioned this pull request Nov 15, 2023

Update Documentation #896

Merged

achimweigel deleted the integrate-ocm-lib branch February 7, 2024 06:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate ocm lib only #837

Integrate ocm lib only #837

achimweigel commented Sep 29, 2023 •

edited

Loading

gardener-prow bot commented Sep 29, 2023

guewa commented Oct 2, 2023

gardener-prow bot commented Oct 2, 2023

guewa commented Oct 2, 2023

gardener-prow bot commented Oct 2, 2023

guewa left a comment •

edited

Loading

fabianburth left a comment

Integrate ocm lib only #837

Integrate ocm lib only #837

Conversation

achimweigel commented Sep 29, 2023 • edited Loading

gardener-prow bot commented Sep 29, 2023

guewa commented Oct 2, 2023

gardener-prow bot commented Oct 2, 2023

guewa commented Oct 2, 2023

gardener-prow bot commented Oct 2, 2023

guewa left a comment • edited Loading

Choose a reason for hiding this comment

fabianburth left a comment

Choose a reason for hiding this comment

achimweigel commented Sep 29, 2023 •

edited

Loading

guewa left a comment •

edited

Loading