Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation #896

Merged
merged 14 commits into from
Nov 23, 2023
Merged

Conversation

fabianburth
Copy link
Collaborator

@fabianburth fabianburth commented Nov 15, 2023

How to categorize this PR?

/area documentation
/kind cleanup
/priority 3

What this PR does / why we need it:
This PR is motivated by the deprecation of the component-cli and is essentially a follow-up to the PRs integrating the ocm-lib into the landscaper to perspectively replace the component-cli (#837, #844) and the adjustment of the templating to also enable component descriptors of schema version v3alpha1 (#863).

This PR cleans up the documentation by updating or removing outdated sections and replacing the legacy component-cli commands with ocm-cli commands.

Thereby, it prepares the removal of the component-cli from the landscaper.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
This PR deletes the entire Tutorials section with all its content. It appears to me, that the content is generally the same as the content of the Guided Tour.

Release note:

Update documentation regarding component-cli replacement with ocm

The contents of this tutorial are essentially covered by the guided tour. Furthermore, this tutorial involves
legacy component-cli and legacy landscaper-cli commands and would therefore require updating.
Copy link

gardener-prow bot commented Nov 15, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 15, 2023
As the gettingstarted directory contains exclusively installation
instructions, installation is a more suitable name that allows to find
the instructions more intuitively. Furthermore a dedicated directory
makes sense (instead of e.g. putting it in the guided tour), since this
is quite important information that is referenced from several
locations.
There should only exist a single document describing the installation of
the landscaper. This makes it easier to keep the documentation clean and
up to date.
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 20, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 20, 2023
For large parts, the content of the tutorials has been superseded by the
guided tour. Again, maintaining redundant documentation causes
unnecessary overhead.
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 20, 2023
This documentation is unfinished and unused. Besides, most of its
content is a duplicate of the guided tour.
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 20, 2023
Inline component descriptors were announced to be deprecated and should
therefore be removed from the documentation.
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 20, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 20, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 20, 2023
@gardener-robot gardener-robot added area/documentation Documentation related kind/cleanup Something that is not needed anymore and can be cleaned up priority/3 Priority (lower number equals higher priority) labels Nov 20, 2023
@fabianburth fabianburth marked this pull request as ready for review November 20, 2023 09:54
@fabianburth fabianburth requested a review from a team as a code owner November 20, 2023 09:54
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 20, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 20, 2023
A previous commit removed the entire docs/tutorial folder since the
content was deemed to be a duplicate of the guided tour. But the
resources in this directory are used by some integration tests.
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 21, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2023
@gardener-robot
Copy link

@Diaphteiros, @achimweigel You have pull request review open invite, please check

@fabianburth fabianburth merged commit 1d2d7f8 into gardener:master Nov 23, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 23, 2023
@fabianburth fabianburth deleted the update-documentation branch November 23, 2023 11:48
guewa pushed a commit that referenced this pull request Dec 5, 2023
* fix faulty example

* Remove manifest-deployer-tutorial

The contents of this tutorial are essentially covered by the guided tour. Furthermore, this tutorial involves
legacy component-cli and legacy landscaper-cli commands and would therefore require updating.

* Move landscaper installation instructions

As the gettingstarted directory contains exclusively installation
instructions, installation is a more suitable name that allows to find
the instructions more intuitively. Furthermore a dedicated directory
makes sense (instead of e.g. putting it in the guided tour), since this
is quite important information that is referenced from several
locations.

* Unify the installation instructions

There should only exist a single document describing the installation of
the landscaper. This makes it easier to keep the documentation clean and
up to date.

* Remove tutorials

For large parts, the content of the tutorials has been superseded by the
guided tour. Again, maintaining redundant documentation causes
unnecessary overhead.

* Remove unfinished and unused documentation

This documentation is unfinished and unused. Besides, most of its
content is a duplicate of the guided tour.

* Remove inline component descriptor from installation scaffold

Inline component descriptors were announced to be deprecated and should
therefore be removed from the documentation.

* Update component descriptor glossary entry

* (run-int-tests)

* Move tutorial resources to corresponding integration tests

A previous commit removed the entire docs/tutorial folder since the
content was deemed to be a duplicate of the guided tour. But the
resources in this directory are used by some integration tests.

* Adjust further references to tutorial resources (run-int-tests)

* (run-int-tests)

* (run-int-tests)

* (run-int-tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation related kind/cleanup Something that is not needed anymore and can be cleaned up needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else priority/3 Priority (lower number equals higher priority) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants