Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong additionalLocations in flavors lead to rejected Testruns #378

Closed
dguendisch opened this issue Nov 17, 2021 · 0 comments · Fixed by #384
Closed

Wrong additionalLocations in flavors lead to rejected Testruns #378

dguendisch opened this issue Nov 17, 2021 · 0 comments · Fixed by #384
Labels

Comments

@dguendisch
Copy link
Member

A flavor snippet like this:

- provider: gcp
  additionalLocations:
  - type: git
  allowPrivilegedContainers: false

Leads to a rendered Testrun that contains a location without any repo and revision and is therefore consequently rejected by the admission webhook.

admission webhook \"validate-testrun.tm.garden.cloud\" denied the request: [spec.locationSets[0].locations[84].repo: Required value: repo has to be defined for git TestDefinition locations, spec.locationSets[0].locations[84].revision: Required value: revision has to be defined for git TestDefinition locations]"

The flavor parsing should instead immediately reject meaningless additionalLocations fields (that have no repo and revision but just a type).

@dguendisch dguendisch added kind/question Question (asking for help, advice, or technical detail) kind/bug Bug and removed kind/question Question (asking for help, advice, or technical detail) labels Nov 17, 2021
hendrikKahl added a commit to hendrikKahl/test-infra that referenced this issue Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant