Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor improvements to testrunner #384

Merged
merged 1 commit into from
Dec 16, 2021
Merged

minor improvements to testrunner #384

merged 1 commit into from
Dec 16, 2021

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area testing
/kind impediment

What this PR does / why we need it:
Some minor improvements of error handling by the testrunner.

  • flavor validation will check additionalLocations[] for completeness
  • testrunner will print the filename when it is not able to parse an already rendered file

Which issue(s) this PR fixes:
Fixes #378

Special notes for your reviewer:

Release note:

validation of additionalLocations for flavors

@hendrikKahl hendrikKahl requested a review from a team as a code owner December 16, 2021 13:21
@gardener-robot gardener-robot added area/testing Testing related kind/impediment Something that impedes developers, operators, users or others in their work needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Dec 16, 2021
@hendrikKahl
Copy link
Contributor Author

/invite @dguendisch

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 16, 2021
dguendisch
dguendisch approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 16, 2021
@hendrikKahl hendrikKahl merged commit c68a3fe into gardener:master Dec 16, 2021
@hendrikKahl hendrikKahl deleted the improvements branch December 16, 2021 14:17
@hendrikKahl
Copy link
Contributor Author

/xkcd

@testmachinery
Copy link

testmachinery bot commented Dec 17, 2021

Bad Map Projection: Liquid Resize link
xkcd image

@gardener-robot
Copy link

@hendrikKahl Command /xkcd is not known.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

Assignees
No one assigned
Labels
area/testing Testing related kind/impediment Something that impedes developers, operators, users or others in their work needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong additionalLocations in flavors lead to rejected Testruns
4 participants
@hendrikKahl @gardener-robot @dguendisch @gardener-robot-ci-1