Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor gardener@v1.51.0 #414

Merged
merged 18 commits into from
Jul 20, 2022
Merged

Vendor gardener@v1.51.0 #414

merged 18 commits into from
Jul 20, 2022

Conversation

acumino
Copy link
Member

@acumino acumino commented Jul 19, 2022 •
edited
Loading

How to categorize this PR?

/area testing
/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Part of https://github.com/gardener/backlog/issues/19

Special notes for your reviewer:

Release note:

The following dependency is updated:
- github.com/gardener/gardener: v1.38.2 -> v1.51.0

@gardener-robot gardener-robot added area/testing Testing related kind/enhancement Enhancement, improvement, extension needs/review Needs review labels Jul 19, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 19, 2022
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jul 19, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 19, 2022
@acumino
Copy link
Member Author

acumino commented Jul 19, 2022

/invite @hendrikKahl
some tests will fail I will adapt changes for them tomorrow.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 19, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 19, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 19, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 20, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 20, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 20, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 20, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2022
@hendrikKahl
Copy link
Contributor

@acumino thanks for the PR!
There is not much to add, but could you please update these images to be in sync with the vendored version of Argo WF?

https://github.com/gardener/test-infra/blob/master/charts/testmachinery/values.yaml#L106-L108

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 20, 2022
dguendisch
dguendisch approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@dguendisch dguendisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jul 20, 2022
@acumino acumino mentioned this pull request Jul 20, 2022
Merged
@hendrikKahl
Copy link
Contributor

hendrikKahl commented Jul 20, 2022 •
edited
Loading

@acumino looks like the argo wf v3.3.x introduces a new CRD... sorry, missed that.

Would you mind adding this CRD to our chart. Also the clusterrole needs to be extended with this?

@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 20, 2022
@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Jul 20, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 20, 2022
hendrikKahl
hendrikKahl approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@hendrikKahl hendrikKahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@acumino great work, thanks a lot!

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Jul 20, 2022
@hendrikKahl hendrikKahl merged commit 3f0c024 into gardener:master Jul 20, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 20, 2022
@acumino acumino deleted the vendor-g/g-1.51 branch February 1, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguendisch dguendisch dguendisch approved these changes

@hendrikKahl hendrikKahl hendrikKahl approved these changes

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

Assignees
No one assigned
Labels
area/testing Testing related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@acumino @gardener-robot @hendrikKahl @dguendisch @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3