-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠ Avoid shallow copies of webhooks and CRDs in testenv #1667
⚠ Avoid shallow copies of webhooks and CRDs in testenv #1667
Conversation
Signed-off-by: Vince Prignano <vincepri@vmware.com>
4b3c568
to
a14a68c
Compare
@vincepri: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @alvaroaleman |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Bump k8s.io/* to v0.23.3 in go.mod * [automated] make revendor * [automated] make generate * Bump c-r to v0.11.0 in go.mod * [automated] make revendor * Bump controller-tools to v0.8.0 in go.mod * [automated] make revendor * Adapt change for Logger changed to Struct From v1.0.0 log.Logger has been changed to struct from Interface. Logger struct has field `LogSink` interface which is same as old `Logger` interface * Adapt changes fo NullLogger * Adapt chnage in Handler API ref kubernetes/kubernetes#105979 * Adapt ResolverConfig field changed from a string to *string ref kubernetes/kunernetes#104624 * Adapt changes for, In kubelet, log verbosity and flush frequency can also be configured via the configuration ref kubernetes/kubernetes#106090 * [automated] make generate * Avoid shallow copies of webhook ref kubernetes-sigs/controller-runtime#1667 * Add back apiserver logging flags * Rebase Co-authored-by: Tim Ebert <timebertt@gmail.com>
* Bump k8s.io/* to v0.23.3 in go.mod * [automated] make revendor * [automated] make generate * Bump c-r to v0.11.0 in go.mod * [automated] make revendor * Bump controller-tools to v0.8.0 in go.mod * [automated] make revendor * Adapt change for Logger changed to Struct From v1.0.0 log.Logger has been changed to struct from Interface. Logger struct has field `LogSink` interface which is same as old `Logger` interface * Adapt changes fo NullLogger * Adapt chnage in Handler API ref kubernetes/kubernetes#105979 * Adapt ResolverConfig field changed from a string to *string ref kubernetes/kunernetes#104624 * Adapt changes for, In kubelet, log verbosity and flush frequency can also be configured via the configuration ref kubernetes/kubernetes#106090 * [automated] make generate * Avoid shallow copies of webhook ref kubernetes-sigs/controller-runtime#1667 * Add back apiserver logging flags * Rebase Co-authored-by: Tim Ebert <timebertt@gmail.com>
* Bump k8s.io/* to v0.23.3 in go.mod * [automated] make revendor * [automated] make generate * Bump c-r to v0.11.0 in go.mod * [automated] make revendor * Bump controller-tools to v0.8.0 in go.mod * [automated] make revendor * Adapt change for Logger changed to Struct From v1.0.0 log.Logger has been changed to struct from Interface. Logger struct has field `LogSink` interface which is same as old `Logger` interface * Adapt changes fo NullLogger * Adapt chnage in Handler API ref kubernetes/kubernetes#105979 * Adapt ResolverConfig field changed from a string to *string ref kubernetes/kunernetes#104624 * Adapt changes for, In kubelet, log verbosity and flush frequency can also be configured via the configuration ref kubernetes/kubernetes#106090 * [automated] make generate * Avoid shallow copies of webhook ref kubernetes-sigs/controller-runtime#1667 * Add back apiserver logging flags * Rebase Co-authored-by: Tim Ebert <timebertt@gmail.com>
* run go mod tidy before go mod vendor to make make revendor * Vendor gardener v1.51.0 * Update k8s dependecies * Update controller-runtime * Import hack * Update Argo Workflow * Update make file to use tools * Update component cli * Update component spec * Update component cli * Adapt changes for NullLogger * Adapt changes for logger changed to construct * Avoid shallow copies of CRDs ref kubernetes-sigs/controller-runtime#1667 * gitignore tools bin dir * make generate and make revendor * delete ignored files * Update images * Add CRDs and adapt cluster role
Signed-off-by: Vince Prignano vincepri@vmware.com
/assign @alvaroaleman