Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): Use new createContentDigest helper #13000

Merged

Conversation

frinyvonnick
Copy link
Contributor

@frinyvonnick frinyvonnick commented Apr 1, 2019

Description

Hi,

Thank you for your work, I use Gatsby on multiple projects and it's really nice 😄 !

This PR makes use of the new createContentDigest helper in the following plugins:

  • gatsby-transformer-excel
  • gatsby-source-hacker-news
  • gatsby-source-wikipedia
  • gatsby-source-wordpress
  • gatsby-transformer-javascript-frontmatter
  • gatsby-source-graphql
  • gatsby-transformer-hjson
  • gatsby-source-npm-package-search
  • gatsby-source-lever
  • gatsby-transformer-javascript-static-exports
  • gatsby-transformer-react-docgen

Related Issues

Related to #8805

@frinyvonnick frinyvonnick force-pushed the topics/createContentDigest-helper branch from 6cd2e88 to 19615ba Compare April 1, 2019 20:46
@frinyvonnick frinyvonnick changed the title ♻️Use new createContentDigest helper in gatsby-transformer-excel and gatsby-source-hacker-news chore(*): Use new createContentDigest helper Apr 2, 2019
@wardpeet wardpeet added the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Apr 5, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect! thanks a lot!

@wardpeet wardpeet merged commit 8166aff into gatsbyjs:master Apr 8, 2019
@gatsbot
Copy link

gatsbot bot commented Apr 8, 2019

Holy buckets, @frinyvonnick — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@sidharthachatterjee
Copy link
Contributor

Love these kind of cleanup PRs! Thank you so much and congratulations on your first contribution @frinyvonnick 🎉

Published in

 - gatsby-transformer-excel@2.1.11
 - gatsby-source-hacker-news@2.0.11
 - gatsby-source-wikipedia@2.0.6
 - gatsby-source-wordpress@3.0.53
 - gatsby-transformer-javascript-frontmatter@2.0.10
 - gatsby-source-graphql@2.0.16
 - gatsby-transformer-hjson@2.1.8
 - gatsby-source-npm-package-search@2.0.5
 - gatsby-source-lever@2.0.8
 - gatsby-transformer-javascript-static-exports@2.1.7
 - gatsby-transformer-react-docgen@4.0.1

@SleeplessByte
Copy link

SleeplessByte commented Apr 8, 2019

FWIW, gatsby-source-graphql (PR 13000) now started erroring with:

TypeError: createContentDigest is not a function

@frinyvonnick
Copy link
Contributor Author

Oh I made a mistake I destructured it from second parameter instead of first parameter...

@SleeplessByte
Copy link

I was about to comment exactly that. Until the fix is pushed, fixing the version on 2.0.15 does still work :)

@frinyvonnick
Copy link
Contributor Author

I made a patch here: #13214

johno pushed a commit to jlengstorf/gatsby that referenced this pull request Apr 10, 2019
## Description
this PR makes use of the new createContentDigest helper in the following plugins:
- gatsby-transformer-excel
- gatsby-source-hacker-news
- gatsby-source-wikipedia
- gatsby-source-wordpress
- gatsby-transformer-javascript-frontmatter
- gatsby-source-graphql
- gatsby-transformer-hjson
- gatsby-source-npm-package-search
- gatsby-source-lever
- gatsby-transformer-javascript-static-exports
- gatsby-transformer-react-docgen
## Related Issues

Related to gatsbyjs#8805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants