Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-graphql): Destructure createContentDigest from first parameter #13214

Merged
merged 3 commits into from
Apr 8, 2019

Conversation

frinyvonnick
Copy link
Contributor

@frinyvonnick frinyvonnick commented Apr 8, 2019

Description

It fixes a wrong import of createContentDigest that breaks gatsby-source-graphql since 2.0.16

Related Issues

Mistake made in a refactoring (#13000)

@frinyvonnick frinyvonnick changed the title 🐛 Destructure createContentDigest from first parameter fix(gatsby-source-graphql): Destructure createContentDigest from first parameter Apr 8, 2019
@frinyvonnick frinyvonnick assigned wardpeet and unassigned wardpeet Apr 8, 2019
@frinyvonnick frinyvonnick requested a review from wardpeet April 8, 2019 14:34
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh whoops - yep, definitely an issue.

Thank you!

@frinyvonnick
Copy link
Contributor Author

frinyvonnick commented Apr 8, 2019

Sorry for making the mistake on first PR 🙏

@DSchau
Copy link
Contributor

DSchau commented Apr 8, 2019

@frinyvonnick re:

Sorry for making the mistake on first PR 🙏

Not at all, and nothing to apologize for! We should've caught that--sorry that we didn't! I've added some unit tests to catch this type of thing in the future, but thanks for identifying that there's an issue and fixing it.

Thank you!

@DSchau DSchau merged commit 382fbe1 into master Apr 8, 2019
@DSchau DSchau deleted the frinyvonnick-patch-gatsby-source-graphql branch April 8, 2019 18:41
@DSchau
Copy link
Contributor

DSchau commented Apr 8, 2019

Successfully published:

  • gatsby-source-graphql@2.0.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants